linux-kernel - Re: [PATCH V2 3/3] arm64: dts: ti: k3-am68-sk: Add support for AM68 SK base board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221115034732.6ssep564capdukrb@smilingly>
Date:   Mon, 14 Nov 2022 21:47:32 -0600
From:   Nishanth Menon <nm@...com>
To:     Sinthu Raja <sinthu.raja@...tralsolutions.com>
CC:     Tero Kristo <kristo@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Vignesh Raghavendra <vigneshr@...com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Sinthu Raja <sinthu.raja@...com>
Subject: Re: [PATCH V2 3/3] arm64: dts: ti: k3-am68-sk: Add support for AM68
 SK base board

On 18:08-20221107, Sinthu Raja wrote:
> From: Sinthu Raja <sinthu.raja@...com>
> 
> The SK architecture comprises of baseboard and a SOM board. The
> AM68 Starter Kit's baseboard contains most of the actual connectors,
> power supply etc. The System on Module (SoM) is plugged on to the base
> board. Therefore, add support for peripherals brought out in the base
> board.
> 
> Schematics: https://www.ti.com/lit/zip/SPRR463
> 
> Signed-off-by: Sinthu Raja <sinthu.raja@...com>
> ---
[...]

> +&main_i2c1 {
> +	status = "disabled";
> +};
> +
> +&main_i2c2 {
> +	status = "disabled";
> +};
> +
> +&main_i2c3 {
> +	status = "disabled";
> +};
> +
> +&main_i2c4 {
> +	status = "disabled";
> +};
> +
> +&main_i2c5 {
> +	status = "disabled";
> +};
> +
> +&main_i2c6 {
> +	status = "disabled";
> +};
> +
> +&main_sdhci0 {
> +	status = "disabled";
> +};

Please revisit all of the nodes to ensure that the ones that are
necessary are enabled? I think most of these are already disabled by
default. We just finished doing a major cleanup.

[...]

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D