linux-kernel - Re: [PATCH V2 4/7] null_blk: don't use magic numbers in the code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f563e7d4-6409-5571-9cba-045c1e42d5f9@nvidia.com>
Date:   Tue, 15 Nov 2022 03:49:35 +0000
From:   Chaitanya Kulkarni <chaitanyak@...dia.com>
To:     Bart Van Assche <bvanassche@....org>,
        Chaitanya Kulkarni <chaitanyak@...dia.com>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "axboe@...nel.dk" <axboe@...nel.dk>,
        "damien.lemoal@...nsource.wdc.com" <damien.lemoal@...nsource.wdc.com>,
        "johannes.thumshirn@....com" <johannes.thumshirn@....com>,
        "ming.lei@...hat.com" <ming.lei@...hat.com>,
        "shinichiro.kawasaki@....com" <shinichiro.kawasaki@....com>,
        "vincent.fu@...sung.com" <vincent.fu@...sung.com>,
        "yukuai3@...wei.com" <yukuai3@...wei.com>
Subject: Re: [PATCH V2 4/7] null_blk: don't use magic numbers in the code

On 11/14/22 16:40, Bart Van Assche wrote:
> On 10/5/22 20:18, Chaitanya Kulkarni wrote:
>> Insteasd of using the hardcoded value use meaningful macro for tag
> 
> Insteasd -> Instead?
> 
>> available value of -1U in get_tag() and __alloc_cmd().
>>
>> While at it return early on error to get rid of the extra indentation
>> in __alloc_cmd().
> 
> Thanks,
> 
> Bart.
> 

thanks for your comment Bart, I'll send out V3 with fixes..

-ck