linux-kernel - Re: [PATCH V2 4/7] null_blk: don't use magic numbers in the code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <475fba10-c471-4922-91d5-3b84c4cce149@acm.org>
Date:   Mon, 14 Nov 2022 16:40:24 -0800
From:   Bart Van Assche <bvanassche@....org>
To:     Chaitanya Kulkarni <kch@...dia.com>, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     axboe@...nel.dk, damien.lemoal@...nsource.wdc.com,
        johannes.thumshirn@....com, ming.lei@...hat.com,
        shinichiro.kawasaki@....com, vincent.fu@...sung.com,
        yukuai3@...wei.com
Subject: Re: [PATCH V2 4/7] null_blk: don't use magic numbers in the code

On 10/5/22 20:18, Chaitanya Kulkarni wrote:
> Insteasd of using the hardcoded value use meaningful macro for tag

Insteasd -> Instead?

> available value of -1U in get_tag() and __alloc_cmd().
> 
> While at it return early on error to get rid of the extra indentation
> in __alloc_cmd().

Thanks,

Bart.