linux-kernel - Re: [PATCH] PCI: vmd: Clean up some inconsistent indenting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y3NpjbXkcb3wfZcQ@infradead.org>
Date:   Tue, 15 Nov 2022 02:27:25 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     nirmal.patel@...ux.intel.com, jonathan.derrick@...ux.dev,
        lpieralisi@...nel.org, robh@...nel.org, kw@...ux.com,
        bhelgaas@...gle.com, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] PCI: vmd: Clean up some inconsistent indenting

On Tue, Nov 15, 2022 at 01:48:47PM +0800, Jiapeng Chong wrote:
> +	if (vmd->irq_domain)
> +		vmd_set_msi_remapping(vmd, true);
> +	else
> +		vmd_set_msi_remapping(vmd, false);

Why not go one step further:

	vmd_set_msi_remapping(vmd, !!vmd->irq_domain);

?