linux-kernel - [PATCH linux-next] btrfs: remove redundant ret variable in delete_v1_space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 15 Nov 2022 09:14:56 +0800 (CST)
From:   <guo.ziliang@....com.cn>
To:     <clm@...com>, <josef@...icpanda.com>
Cc:     <dsterba@...e.com>, <linux-btrfs@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <guo.ziliang@....com.cn>
Subject: [PATCH linux-next] btrfs: remove redundant ret variable in delete_v1_space_cache

From: guo ziliang <guo.ziliang@....com.cn>
Return value from delete_block_group_cache() directly instead of taking
this in another redundant variable.

Signed-off-by: guo ziliang <guo.ziliang@....com.cn>
---
 fs/btrfs/relocation.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c
index 56c8afa..d7f76cf 100644
--- a/fs/btrfs/relocation.c
+++ b/fs/btrfs/relocation.c
@@ -3374,7 +3374,6 @@ static int delete_v1_space_cache(struct extent_buffer *leaf,
        struct btrfs_key key;
        bool found = false;
        int i;
-       int ret;

        if (btrfs_header_owner(leaf) != BTRFS_ROOT_TREE_OBJECTID)
                return 0;
@@ -3398,9 +3397,8 @@ static int delete_v1_space_cache(struct extent_buffer *leaf,
        }
        if (!found)
                return -ENOENT;
-       ret = delete_block_group_cache(leaf->fs_info, block_group, NULL,
+       return delete_block_group_cache(leaf->fs_info, block_group, NULL,
                                        space_cache_ino);
-       return ret;
 }

 /*
--
1.8.3.1