linux-kernel - Re: [PATCH linux-next] btrfs: remove redundant ret variable in delete_v1_space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221115131121.GF5824@twin.jikos.cz>
Date:   Tue, 15 Nov 2022 14:11:21 +0100
From:   David Sterba <dsterba@...e.cz>
To:     guo.ziliang@....com.cn
Cc:     clm@...com, josef@...icpanda.com, dsterba@...e.com,
        linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH linux-next] btrfs: remove redundant ret variable in
 delete_v1_space_cache

On Tue, Nov 15, 2022 at 09:14:56AM +0800, guo.ziliang@....com.cn wrote:
> From: guo ziliang <guo.ziliang@....com.cn>
> Return value from delete_block_group_cache() directly instead of taking
> this in another redundant variable.

Have you found this manually or by some tool? I did a quick grep and
found 14 other cases that could be simplified like that. I'm not sure if
we really need it, but if you fix more than one case then lets do it.