linux-kernel - Re: [PATCH v2 1/2] x86/of: Add support for boot time interrupt delivery mode configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y3Tm9htYb1fwyRXH@smile.fi.intel.com>
Date:   Wed, 16 Nov 2022 15:34:46 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Rahul Tanwar <rtanwar@...linear.com>
Cc:     "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "robh@...nel.org" <robh@...nel.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "bp@...en8.de" <bp@...en8.de>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "x86@...nel.org" <x86@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "hpa@...or.com" <hpa@...or.com>,
        "alan@...rguk.ukuu.org.uk" <alan@...rguk.ukuu.org.uk>,
        "dirk.brandewie@...il.com" <dirk.brandewie@...il.com>,
        "grant.likely@...retlab.ca" <grant.likely@...retlab.ca>,
        "sodaville@...utronix.de" <sodaville@...utronix.de>,
        "devicetree-discuss@...ts.ozlabs.org" 
        <devicetree-discuss@...ts.ozlabs.org>,
        linux-lgm-soc <linux-lgm-soc@...linear.com>
Subject: Re: [PATCH v2 1/2] x86/of: Add support for boot time interrupt
 delivery mode configuration

On Wed, Nov 16, 2022 at 11:25:47AM +0000, Rahul Tanwar wrote:
> On 16/11/2022 6:42 pm, Andy Shevchenko wrote:
> > On Wed, Nov 16, 2022 at 06:28:20PM +0800, Rahul Tanwar wrote:

...

> > Why not pr_notice() in both cases?
> 
> Reset of the file uses printk(KERN_xxx ""). In v1, i used pr_notice() 
> but on reviewing again found it to be odd one out in the file. So 
> switched to printk(KERN_xxx ""). I can revert back to using pr_notice() 
> if you think that's a better fit. Thanks.

I don;t know why we should use antique style of printing APIs in new patches.
Even if the old code uses that, you can create a followup that can do two
things:
- uses pr_lvl() instead of printk(KERN_LVL)
- keeps string literals unbroken between the lines (if any
  of such breakage exists)

-- 
With Best Regards,
Andy Shevchenko