linux-kernel - Re: [PATCH] media: i2c: refer to config VIDEO_DEV to make ov08x40 image sensor driver usable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 16 Nov 2022 13:35:12 +0000
From:   Kieran Bingham <kieran.bingham@...asonboard.com>
To:     Jason Chen <jason.z.chen@...el.com>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Shawn Tu <shawnx.tu@...el.com>, linux-media@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Lukas Bulwahn <lukas.bulwahn@...il.com>
Subject: Re: [PATCH] media: i2c: refer to config VIDEO_DEV to make ov08x40 image sensor driver usable

Quoting Lukas Bulwahn (2022-11-16 09:40:06)
> Commit 9958d30f38b9 ("media: Kconfig: cleanup VIDEO_DEV dependencies")
> removes the config VIDEO_V4L2 as it is merged with config VIDEO_DEV.
> 
> Long after this change, commit 38fc5136ac16 ("media: i2c: Add ov08x40 image
> sensor driver") introduces and refers to the removed config VIDEO_V4L2,
> basically making this driver impossible to build, test and use due to
> dependencies that cannot be met.
> 
> Refer to config VIDEO_DEV instead to make this driver usable.


Fixes: 38fc5136ac16 ("media: i2c: Add ov08x40 image sensor driver")
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>

> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>
> ---
>  drivers/media/i2c/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index 49c1c27afdc1..4a4ae9c20119 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -366,7 +366,7 @@ config VIDEO_OV08D10
>  
>  config VIDEO_OV08X40
>         tristate "OmniVision OV08X40 sensor support"
> -       depends on VIDEO_V4L2 && I2C
> +       depends on VIDEO_DEV && I2C
>         select MEDIA_CONTROLLER
>         select VIDEO_V4L2_SUBDEV_API
>         select V4L2_FWNODE
> -- 
> 2.17.1
>