linux-kernel - [PATCH 1/6] parport_pc: Remove stale `parport_pc_ecp_read_block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.2211160000140.54611@angie.orcam.me.uk>
Date:   Wed, 16 Nov 2022 21:35:52 +0000 (GMT)
From:   "Maciej W. Rozycki" <macro@...am.me.uk>
To:     Sudip Mukherjee <sudipm.mukherjee@...il.com>
cc:     linux-kernel@...r.kernel.org
Subject: [PATCH 1/6] parport_pc: Remove stale `parport_pc_ecp_read_block_pio'
 reference

Complement commit 991214386dee ("parport: remove unused dead code from 
lowlevel drivers") and remove a stale piece of commented-out code that 
refers to a function removed with said commit.

Signed-off-by: Maciej W. Rozycki <macro@...am.me.uk>
---
 drivers/parport/parport_pc.c |    2 --
 1 file changed, 2 deletions(-)

linux-parport-pc-ecp-read-block-pio-call.diff
Index: linux-macro/drivers/parport/parport_pc.c
===================================================================
--- linux-macro.orig/drivers/parport/parport_pc.c
+++ linux-macro/drivers/parport/parport_pc.c
@@ -2119,8 +2119,6 @@ struct parport *parport_pc_probe_port(un
 		p->ops->compat_write_data = parport_pc_compat_write_block_pio;
 #ifdef CONFIG_PARPORT_1284
 		p->ops->ecp_write_data = parport_pc_ecp_write_block_pio;
-		/* currently broken, but working on it.. (FB) */
-		/* p->ops->ecp_read_data = parport_pc_ecp_read_block_pio; */
 #endif /* IEEE 1284 support */
 		if (p->dma != PARPORT_DMA_NONE) {
 			pr_cont(", dma %d", p->dma);