linux-kernel - Re: [PATCH v3 02/10] dm: remove free_table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y3VbQsjmNW4GQHLs@redhat.com>
Date:   Wed, 16 Nov 2022 16:50:58 -0500
From:   Mike Snitzer <snitzer@...hat.com>
To:     Yu Kuai <yukuai1@...weicloud.com>
Cc:     hch@....de, axboe@...nel.dk, agk@...hat.com, snitzer@...nel.org,
        dm-devel@...hat.com, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, yukuai3@...wei.com,
        yi.zhang@...wei.com
Subject: Re: [PATCH v3 02/10] dm: remove free_table_devices

On Tue, Nov 15 2022 at  9:10P -0500,
Yu Kuai <yukuai1@...weicloud.com> wrote:

> From: Christoph Hellwig <hch@....de>
> 
> free_table_devices just warns and frees all table_device structures when
> the target removal did not remove them.  This should never happen, but
> if it did, just freeing the structure without deleting them from the
> list or cleaning up the resources would not help at all.  So just WARN on
> a non-empty list instead.
> 
> Signed-off-by: Christoph Hellwig <hch@....de>
> Signed-off-by: Yu Kuai <yukuai3@...wei.com>

Reviewed-by: Mike Snitzer <snitzer@...nel.org>