linux-kernel - Re: [PATCH v3 01/10] block: clear ->slave_dir when dropping the main slave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y3Vf7LYexIXiUeOE@redhat.com>
Date:   Wed, 16 Nov 2022 17:10:52 -0500
From:   Mike Snitzer <snitzer@...hat.com>
To:     Yu Kuai <yukuai1@...weicloud.com>
Cc:     hch@....de, axboe@...nel.dk, agk@...hat.com, snitzer@...nel.org,
        dm-devel@...hat.com, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, yukuai3@...wei.com,
        yi.zhang@...wei.com
Subject: Re: [PATCH v3 01/10] block: clear ->slave_dir when dropping the main
 slave_dir reference

On Tue, Nov 15 2022 at  9:10P -0500,
Yu Kuai <yukuai1@...weicloud.com> wrote:

> From: Christoph Hellwig <hch@....de>
> 
> Zero out the pointer to ->slave_dir so that the holder code doesn't
> incorrectly treat the object as alive when add_disk failed or after
> del_gendisk was called.
> 
> Fixes: 89f871af1b26 ("dm: delay registering the gendisk")
> Reported-by: Yu Kuai <yukuai3@...wei.com>
> Signed-off-by: Christoph Hellwig <hch@....de>
> Signed-off-by: Yu Kuai <yukuai3@...wei.com>

Reviewed-by: Mike Snitzer <snitzer@...nel.org>