lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0505aac0-b861-d8ed-e310-b2723dd1871c@linaro.org>
Date:   Wed, 16 Nov 2022 11:43:40 +0100
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Johan Hovold <johan+linaro@...nel.org>,
        Mark Brown <broonie@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>
Cc:     Andy Gross <agross@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Douglas Anderson <dianders@...omium.org>,
        Parikshit Pareek <quic_ppareek@...cinc.com>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: clean up 'regulator-allowed-modes'
 indentation



On 16/11/2022 11:20, Johan Hovold wrote:
> When recently adding the missing 'regulator-allowed-modes' properties it
> appears that the binding example with its four-spaces indentation
> (corresponding to a single tab, which is still to little) was copied
> verbatim.
> 
> Drop the unnecessary first line break after 'regulator-allowed-modes'
> properties and indent the single remaining continuation line properly.
> 
> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad
>   arch/arm64/boot/dts/qcom/sa8155p-adp.dts      | 20 ++++++++-----------
>   arch/arm64/boot/dts/qcom/sa8295p-adp.dts      | 20 ++++++++-----------
>   arch/arm64/boot/dts/qcom/sc8280xp-crd.dts     | 10 ++++------
>   .../qcom/sm6350-sony-xperia-lena-pdx213.dts   | 10 ++++------
>   .../boot/dts/qcom/sm7225-fairphone-fp4.dts    | 10 ++++------
>   .../dts/qcom/sm8150-sony-xperia-kumano.dtsi   | 10 ++++------
>   .../boot/dts/qcom/sm8250-sony-xperia-edo.dtsi | 10 ++++------
>   arch/arm64/boot/dts/qcom/sm8350-hdk.dts       | 20 ++++++++-----------
>   8 files changed, 44 insertions(+), 66 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
> index 01ac460d910e..952acfc04adc 100644
> --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
> +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
> @@ -136,9 +136,8 @@ vreg_l5a_0p88: ldo5 {
>   			regulator-max-microvolt = <880000>;
>   			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>   			regulator-allow-set-load;
> -			regulator-allowed-modes =
> -			    <RPMH_REGULATOR_MODE_LPM
> -			     RPMH_REGULATOR_MODE_HPM>;
> +			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> +						   RPMH_REGULATOR_MODE_HPM>;
>   		};
>   
>   		vreg_l7a_1p8: ldo7 {
> @@ -154,9 +153,8 @@ vreg_l10a_2p96: ldo10 {
>   			regulator-max-microvolt = <2960000>;
>   			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>   			regulator-allow-set-load;
> -			regulator-allowed-modes =
> -			    <RPMH_REGULATOR_MODE_LPM
> -			     RPMH_REGULATOR_MODE_HPM>;
> +			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> +						   RPMH_REGULATOR_MODE_HPM>;
>   		};
>   
>   		vreg_l11a_0p8: ldo11 {
> @@ -263,9 +261,8 @@ vreg_l5c_1p2: ldo5 {
>   			regulator-max-microvolt = <1200000>;
>   			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>   			regulator-allow-set-load;
> -			regulator-allowed-modes =
> -			    <RPMH_REGULATOR_MODE_LPM
> -			     RPMH_REGULATOR_MODE_HPM>;
> +			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> +						   RPMH_REGULATOR_MODE_HPM>;
>   		};
>   
>   		vreg_l7c_1p8: ldo7 {
> @@ -281,9 +278,8 @@ vreg_l8c_1p2: ldo8 {
>   			regulator-max-microvolt = <1200000>;
>   			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>   			regulator-allow-set-load;
> -			regulator-allowed-modes =
> -			    <RPMH_REGULATOR_MODE_LPM
> -			     RPMH_REGULATOR_MODE_HPM>;
> +			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> +						   RPMH_REGULATOR_MODE_HPM>;
>   		};
>   
>   		vreg_l10c_3p3: ldo10 {
> diff --git a/arch/arm64/boot/dts/qcom/sa8295p-adp.dts b/arch/arm64/boot/dts/qcom/sa8295p-adp.dts
> index 6c29d7d757e0..51805106f542 100644
> --- a/arch/arm64/boot/dts/qcom/sa8295p-adp.dts
> +++ b/arch/arm64/boot/dts/qcom/sa8295p-adp.dts
> @@ -90,9 +90,8 @@ vreg_l3c: ldo3 {
>   			regulator-max-microvolt = <1200000>;
>   			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>   			regulator-allow-set-load;
> -			regulator-allowed-modes =
> -			    <RPMH_REGULATOR_MODE_LPM
> -			     RPMH_REGULATOR_MODE_HPM>;
> +			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> +						   RPMH_REGULATOR_MODE_HPM>;
>   		};
>   
>   		vreg_l4c: ldo4 {
> @@ -108,9 +107,8 @@ vreg_l6c: ldo6 {
>   			regulator-max-microvolt = <1200000>;
>   			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>   			regulator-allow-set-load;
> -			regulator-allowed-modes =
> -			    <RPMH_REGULATOR_MODE_LPM
> -			     RPMH_REGULATOR_MODE_HPM>;
> +			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> +						   RPMH_REGULATOR_MODE_HPM>;
>   		};
>   
>   		vreg_l7c: ldo7 {
> @@ -126,9 +124,8 @@ vreg_l10c: ldo10 {
>   			regulator-max-microvolt = <2504000>;
>   			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>   			regulator-allow-set-load;
> -			regulator-allowed-modes =
> -			    <RPMH_REGULATOR_MODE_LPM
> -			     RPMH_REGULATOR_MODE_HPM>;
> +			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> +						   RPMH_REGULATOR_MODE_HPM>;
>   		};
>   
>   		vreg_l17c: ldo17 {
> @@ -137,9 +134,8 @@ vreg_l17c: ldo17 {
>   			regulator-max-microvolt = <2504000>;
>   			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>   			regulator-allow-set-load;
> -			regulator-allowed-modes =
> -			    <RPMH_REGULATOR_MODE_LPM
> -			     RPMH_REGULATOR_MODE_HPM>;
> +			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> +						   RPMH_REGULATOR_MODE_HPM>;
>   		};
>   	};
>   
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> index f09810e3d956..551768f97729 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> @@ -170,9 +170,8 @@ vreg_l7c: ldo7 {
>   			regulator-max-microvolt = <2504000>;
>   			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>   			regulator-allow-set-load;
> -			regulator-allowed-modes =
> -			    <RPMH_REGULATOR_MODE_LPM
> -			     RPMH_REGULATOR_MODE_HPM>;
> +			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> +						   RPMH_REGULATOR_MODE_HPM>;
>   		};
>   
>   		vreg_l13c: ldo13 {
> @@ -195,9 +194,8 @@ vreg_l3d: ldo3 {
>   			regulator-max-microvolt = <1200000>;
>   			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>   			regulator-allow-set-load;
> -			regulator-allowed-modes =
> -			    <RPMH_REGULATOR_MODE_LPM
> -			     RPMH_REGULATOR_MODE_HPM>;
> +			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> +						   RPMH_REGULATOR_MODE_HPM>;
>   		};
>   
>   		vreg_l4d: ldo4 {
> diff --git a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
> index 20f35623d1ef..94f77d376662 100644
> --- a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
> +++ b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
> @@ -231,9 +231,8 @@ pm6150l_l6: ldo6 {
>   			regulator-max-microvolt = <2950000>;
>   			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>   			regulator-allow-set-load;
> -			regulator-allowed-modes =
> -			    <RPMH_REGULATOR_MODE_LPM
> -			     RPMH_REGULATOR_MODE_HPM>;
> +			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> +						   RPMH_REGULATOR_MODE_HPM>;
>   
>   		};
>   
> @@ -254,9 +253,8 @@ pm6150l_l9: ldo9 {
>   			regulator-max-microvolt = <2960000>;
>   			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>   			regulator-allow-set-load;
> -			regulator-allowed-modes =
> -			    <RPMH_REGULATOR_MODE_LPM
> -			     RPMH_REGULATOR_MODE_HPM>;
> +			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> +						   RPMH_REGULATOR_MODE_HPM>;
>   
>   		};
>   
> diff --git a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> index 1cb14051ab1b..c456e9594ea5 100644
> --- a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> +++ b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> @@ -282,9 +282,8 @@ vreg_l6e: ldo6 {
>   			regulator-max-microvolt = <2950000>;
>   			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>   			regulator-allow-set-load;
> -			regulator-allowed-modes =
> -				<RPMH_REGULATOR_MODE_LPM
> -				 RPMH_REGULATOR_MODE_HPM>;
> +			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> +						   RPMH_REGULATOR_MODE_HPM>;
>   		};
>   
>   		vreg_l7e: ldo7 {
> @@ -304,9 +303,8 @@ vreg_l9e: ldo9 {
>   			regulator-max-microvolt = <2960000>;
>   			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>   			regulator-allow-set-load;
> -			regulator-allowed-modes =
> -				<RPMH_REGULATOR_MODE_LPM
> -				 RPMH_REGULATOR_MODE_HPM>;
> +			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> +						   RPMH_REGULATOR_MODE_HPM>;
>   		};
>   
>   		vreg_l10e: ldo10 {
> diff --git a/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi b/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi
> index fb6e5a140c9f..c958a8b16730 100644
> --- a/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi
> @@ -348,9 +348,8 @@ vreg_l6c_2p9: ldo6 {
>   			regulator-max-microvolt = <2960000>;
>   			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>   			regulator-allow-set-load;
> -			regulator-allowed-modes =
> -			    <RPMH_REGULATOR_MODE_LPM
> -			     RPMH_REGULATOR_MODE_HPM>;
> +			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> +						   RPMH_REGULATOR_MODE_HPM>;
>   		};
>   
>   		vreg_l7c_3p0: ldo7 {
> @@ -370,9 +369,8 @@ vreg_l9c_2p9: ldo9 {
>   			regulator-max-microvolt = <2960000>;
>   			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>   			regulator-allow-set-load;
> -			regulator-allowed-modes =
> -			    <RPMH_REGULATOR_MODE_LPM
> -			     RPMH_REGULATOR_MODE_HPM>;
> +			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> +						   RPMH_REGULATOR_MODE_HPM>;
>   		};
>   
>   		vreg_l10c_3p3: ldo10 {
> diff --git a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
> index 2a223ed50102..38746f248969 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
> @@ -317,9 +317,8 @@ vreg_l6c_2p9: ldo6 {
>   			regulator-max-microvolt = <2960000>;
>   			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>   			regulator-allow-set-load;
> -			regulator-allowed-modes =
> -			    <RPMH_REGULATOR_MODE_LPM
> -			     RPMH_REGULATOR_MODE_HPM>;
> +			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> +						   RPMH_REGULATOR_MODE_HPM>;
>   		};
>   
>   		vreg_l7c_2p85: ldo7 {
> @@ -342,9 +341,8 @@ vreg_l9c_2p9: ldo9 {
>   			regulator-max-microvolt = <2960000>;
>   			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>   			regulator-allow-set-load;
> -			regulator-allowed-modes =
> -			    <RPMH_REGULATOR_MODE_LPM
> -			     RPMH_REGULATOR_MODE_HPM>;
> +			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> +						   RPMH_REGULATOR_MODE_HPM>;
>   		};
>   
>   		vreg_l10c_3p3: ldo10 {
> diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
> index 69ae6503c2f6..26a608144886 100644
> --- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
> @@ -107,9 +107,8 @@ vreg_l5b_0p88: ldo5 {
>   			regulator-max-microvolt = <888000>;
>   			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>   			regulator-allow-set-load;
> -			regulator-allowed-modes =
> -			    <RPMH_REGULATOR_MODE_LPM
> -			     RPMH_REGULATOR_MODE_HPM>;
> +			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> +						   RPMH_REGULATOR_MODE_HPM>;
>   		};
>   
>   		vreg_l6b_1p2: ldo6 {
> @@ -118,9 +117,8 @@ vreg_l6b_1p2: ldo6 {
>   			regulator-max-microvolt = <1208000>;
>   			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>   			regulator-allow-set-load;
> -			regulator-allowed-modes =
> -			    <RPMH_REGULATOR_MODE_LPM
> -			     RPMH_REGULATOR_MODE_HPM>;
> +			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> +						   RPMH_REGULATOR_MODE_HPM>;
>   		};
>   
>   		vreg_l7b_2p96: ldo7 {
> @@ -129,9 +127,8 @@ vreg_l7b_2p96: ldo7 {
>   			regulator-max-microvolt = <2504000>;
>   			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>   			regulator-allow-set-load;
> -			regulator-allowed-modes =
> -			    <RPMH_REGULATOR_MODE_LPM
> -			     RPMH_REGULATOR_MODE_HPM>;
> +			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> +						   RPMH_REGULATOR_MODE_HPM>;
>   		};
>   
>   		vreg_l9b_1p2: ldo9 {
> @@ -140,9 +137,8 @@ vreg_l9b_1p2: ldo9 {
>   			regulator-max-microvolt = <1200000>;
>   			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>   			regulator-allow-set-load;
> -			regulator-allowed-modes =
> -			    <RPMH_REGULATOR_MODE_LPM
> -			     RPMH_REGULATOR_MODE_HPM>;
> +			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> +						   RPMH_REGULATOR_MODE_HPM>;
>   		};
>   	};
>   

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ