linux-kernel - Re: [PATCH 0/2] irqchip: Kconfig: Add module support for TI inta/intr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 17 Nov 2022 21:00:07 +0000
From:   Marc Zyngier <maz@...nel.org>
To:     Nicolas Frayer <nfrayer@...libre.com>
Cc:     tglx@...utronix.de, linux-kernel@...r.kernel.org,
        khilman@...libre.com, glaroque@...libre.com
Subject: Re: [PATCH 0/2] irqchip: Kconfig: Add module support for TI inta/intr

On Thu, 17 Nov 2022 20:49:58 +0000,
Nicolas Frayer <nfrayer@...libre.com> wrote:
> 
> Le mer. 16 nov. 2022 à 22:44, Marc Zyngier <maz@...nel.org> a écrit :
> >
> > On Wed, 16 Nov 2022 18:54:58 +0000,
> > Nicolas Frayer <nfrayer@...libre.com> wrote:
> > >
> > > Added module support for TI interrupt aggregator and interrupt router
> > >
> > > Nicolas Frayer (2):
> > >   irqchip: Kconfig: module build support for the TI interrupt router
> > >     driver
> > >   irqchip: Kconfig: Added module build support for the TI interrupt
> > >     aggregator
> > >
> > >  arch/arm64/Kconfig.platforms |  2 --
> > >  drivers/irqchip/Kconfig      | 12 +++++++-----
> > >  2 files changed, 7 insertions(+), 7 deletions(-)
> >
> > How did you test that it doesn't introduce any regression due to
> > implicit ordering requirements that are now voided?
> Hi Marc,
> I tested on a TI AM62x SK board.
> By default the drivers are set to ARCH_K3 (built-in).

That wasn't exactly my question: even if they are by sefault set as
built-in, you still run the risk of exposing some breakage for
endpoint drivers that expect the irqchip to be present before they get
initialised. Every time an interrupt controller gets modularised, we
end-up with a ton of failures.

A good way to test this is to run a distro kernel with all the drivers
build as modules.

> >
> > Please Cc the TI folks so that they can at least check this.
> I'll resend the series with more description and CC Ti engineers.

Please also see the kernel robot result: this stuff now gets compiled
on unsuspecting architectures, and fails.

	M.

-- 
Without deviation from the norm, progress is not possible.