linux-kernel - Re: [PATCH 1/2] irqchip: Kconfig: module build support for the TI interrupt router driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 27 Nov 2022 06:03:10 +0800
From:   kernel test robot <lkp@...el.com>
To:     Nicolas Frayer <nfrayer@...libre.com>, tglx@...utronix.de,
        maz@...nel.org, linux-kernel@...r.kernel.org
Cc:     oe-kbuild-all@...ts.linux.dev, khilman@...libre.com,
        glaroque@...libre.com, nfrayer@...libre.com
Subject: Re: [PATCH 1/2] irqchip: Kconfig: module build support for the TI
 interrupt router driver

Hi Nicolas,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on arm64/for-next/core]
[also build test ERROR on tip/irq/core linus/master v6.1-rc6 next-20221125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Nicolas-Frayer/irqchip-Kconfig-Add-module-support-for-TI-inta-intr/20221117-025707
base:   https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
patch link:    https://lore.kernel.org/r/20221116185500.40431-2-nfrayer%40baylibre.com
patch subject: [PATCH 1/2] irqchip: Kconfig: module build support for the TI interrupt router driver
config: loongarch-randconfig-r012-20221127
compiler: loongarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/3755b38d1b3c55bba2be7106a9e6ead082a7d92f
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Nicolas-Frayer/irqchip-Kconfig-Add-module-support-for-TI-inta-intr/20221117-025707
        git checkout 3755b38d1b3c55bba2be7106a9e6ead082a7d92f
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=loongarch SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   loongarch64-linux-ld: drivers/firmware/ti_sci.o: in function `.L8':
>> drivers/firmware/ti_sci.c:3510: undefined reference to `mbox_free_channel'
>> loongarch64-linux-ld: drivers/firmware/ti_sci.c:3511: undefined reference to `mbox_free_channel'

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for TI_SCI_PROTOCOL
   Depends on [n]: TI_MESSAGE_MANAGER [=n] || TI_MESSAGE_MANAGER [=n]
   Selected by [y]:
   - TI_SCI_INTR_IRQCHIP [=y]


vim +3510 drivers/firmware/ti_sci.c

aa276781a64a5f Nishanth Menon 2016-10-18  3485  
aa276781a64a5f Nishanth Menon 2016-10-18  3486  static int ti_sci_remove(struct platform_device *pdev)
aa276781a64a5f Nishanth Menon 2016-10-18  3487  {
aa276781a64a5f Nishanth Menon 2016-10-18  3488  	struct ti_sci_info *info;
aa276781a64a5f Nishanth Menon 2016-10-18  3489  	struct device *dev = &pdev->dev;
aa276781a64a5f Nishanth Menon 2016-10-18  3490  	int ret = 0;
aa276781a64a5f Nishanth Menon 2016-10-18  3491  
aa276781a64a5f Nishanth Menon 2016-10-18  3492  	of_platform_depopulate(dev);
aa276781a64a5f Nishanth Menon 2016-10-18  3493  
aa276781a64a5f Nishanth Menon 2016-10-18  3494  	info = platform_get_drvdata(pdev);
aa276781a64a5f Nishanth Menon 2016-10-18  3495  
912cffb4ed8612 Nishanth Menon 2016-10-18  3496  	if (info->nb.notifier_call)
912cffb4ed8612 Nishanth Menon 2016-10-18  3497  		unregister_restart_handler(&info->nb);
912cffb4ed8612 Nishanth Menon 2016-10-18  3498  
aa276781a64a5f Nishanth Menon 2016-10-18  3499  	mutex_lock(&ti_sci_list_mutex);
aa276781a64a5f Nishanth Menon 2016-10-18  3500  	if (info->users)
aa276781a64a5f Nishanth Menon 2016-10-18  3501  		ret = -EBUSY;
aa276781a64a5f Nishanth Menon 2016-10-18  3502  	else
aa276781a64a5f Nishanth Menon 2016-10-18  3503  		list_del(&info->node);
aa276781a64a5f Nishanth Menon 2016-10-18  3504  	mutex_unlock(&ti_sci_list_mutex);
aa276781a64a5f Nishanth Menon 2016-10-18  3505  
aa276781a64a5f Nishanth Menon 2016-10-18  3506  	if (!ret) {
aa276781a64a5f Nishanth Menon 2016-10-18  3507  		ti_sci_debugfs_destroy(pdev, info);
aa276781a64a5f Nishanth Menon 2016-10-18  3508  
aa276781a64a5f Nishanth Menon 2016-10-18  3509  		/* Safe to free channels since no more users */
aa276781a64a5f Nishanth Menon 2016-10-18 @3510  		mbox_free_channel(info->chan_tx);
aa276781a64a5f Nishanth Menon 2016-10-18 @3511  		mbox_free_channel(info->chan_rx);
aa276781a64a5f Nishanth Menon 2016-10-18  3512  	}
aa276781a64a5f Nishanth Menon 2016-10-18  3513  
aa276781a64a5f Nishanth Menon 2016-10-18  3514  	return ret;
aa276781a64a5f Nishanth Menon 2016-10-18  3515  }
aa276781a64a5f Nishanth Menon 2016-10-18  3516  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (139451 bytes)