linux-kernel - Re: linux-next: manual merge of the drm-misc tree with the origin tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221118090636.00bfc293@canb.auug.org.au>
Date:   Fri, 18 Nov 2022 09:06:36 +1100
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Nathan Chancellor <nathan@...nel.org>
Cc:     Daniel Vetter <daniel.vetter@...ll.ch>,
        Intel Graphics <intel-gfx@...ts.freedesktop.org>,
        DRI <dri-devel@...ts.freedesktop.org>,
        José Expósito <jose.exposito89@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Maxime Ripard <maxime@...no.tech>, llvm@...ts.linux.dev
Subject: Re: linux-next: manual merge of the drm-misc tree with the origin
 tree

Hi Nathan,

On Thu, 17 Nov 2022 10:29:33 -0700 Nathan Chancellor <nathan@...nel.org> wrote:
>
> This resolution is not quite right, as pointed out by clang:
> 
>     drivers/gpu/drm/vc4/vc4_hdmi.c:351:14: error: variable 'vc4_hdmi' is uninitialized when used here [-Werror,-Wuninitialized]
>             mutex_lock(&vc4_hdmi->mutex);
>                         ^~~~~~~~
>     ./include/linux/mutex.h:187:44: note: expanded from macro 'mutex_lock'
>     #define mutex_lock(lock) mutex_lock_nested(lock, 0)
>                                                ^~~~
>     drivers/gpu/drm/vc4/vc4_hdmi.c:322:27: note: initialize the variable 'vc4_hdmi' to silence this warning
>             struct vc4_hdmi *vc4_hdmi;
>                                      ^
>                                       = NULL
>     1 error generated.
> 
> Obviously, the assignment of vc4_hdmi should be before mutex_lock().

Thanks for pointing that out (silly me :-) ).  I have fixed up the
resolution for today.

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped