[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y3bLRLDCrd7KYqom@dev-arch.thelio-3990X>
Date: Thu, 17 Nov 2022 17:01:08 -0700
From: Nathan Chancellor <nathan@...nel.org>
To: Stephen Rothwell <sfr@...b.auug.org.au>
Cc: Daniel Vetter <daniel.vetter@...ll.ch>,
Intel Graphics <intel-gfx@...ts.freedesktop.org>,
DRI <dri-devel@...ts.freedesktop.org>,
José Expósito <jose.exposito89@...il.com>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Linux Next Mailing List <linux-next@...r.kernel.org>,
Maxime Ripard <maxime@...no.tech>, llvm@...ts.linux.dev
Subject: Re: linux-next: manual merge of the drm-misc tree with the origin
tree
On Fri, Nov 18, 2022 at 09:06:36AM +1100, Stephen Rothwell wrote:
> Hi Nathan,
>
> On Thu, 17 Nov 2022 10:29:33 -0700 Nathan Chancellor <nathan@...nel.org> wrote:
> >
> > This resolution is not quite right, as pointed out by clang:
> >
> > drivers/gpu/drm/vc4/vc4_hdmi.c:351:14: error: variable 'vc4_hdmi' is uninitialized when used here [-Werror,-Wuninitialized]
> > mutex_lock(&vc4_hdmi->mutex);
> > ^~~~~~~~
> > ./include/linux/mutex.h:187:44: note: expanded from macro 'mutex_lock'
> > #define mutex_lock(lock) mutex_lock_nested(lock, 0)
> > ^~~~
> > drivers/gpu/drm/vc4/vc4_hdmi.c:322:27: note: initialize the variable 'vc4_hdmi' to silence this warning
> > struct vc4_hdmi *vc4_hdmi;
> > ^
> > = NULL
> > 1 error generated.
> >
> > Obviously, the assignment of vc4_hdmi should be before mutex_lock().
>
> Thanks for pointing that out (silly me :-) ). I have fixed up the
> resolution for today.
Great, thank you so much! One less warning to worry about :)
Cheers,
Nathan
Powered by blists - more mailing lists