linux-kernel - Re: [PATCH linux-next] power: supply: core: Use device_match_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221117223259.h75ufpadvt2prkfh@mercury.elektranox.org>
Date:   Thu, 17 Nov 2022 23:32:59 +0100
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     ye.xingchen@....com.cn
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH linux-next] power: supply: core: Use
 device_match_of_node()

Hi,

On Thu, Nov 17, 2022 at 03:30:03PM +0800, ye.xingchen@....com.cn wrote:
> From: ye xingchen <ye.xingchen@....com.cn>
> 
> Replace the open-code with device_match_of_node().
> 
> Signed-off-by: ye xingchen <ye.xingchen@....com.cn>
> ---

struct power_supply != struct device

-- Sebastian

>  drivers/power/supply/power_supply_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/supply/power_supply_core.c b/drivers/power/supply/power_supply_core.c
> index 9035e349bf53..46d0cb0c5026 100644
> --- a/drivers/power/supply/power_supply_core.c
> +++ b/drivers/power/supply/power_supply_core.c
> @@ -203,7 +203,7 @@ static int  __power_supply_find_supply_from_node(struct device *dev,
>  	struct power_supply *epsy = dev_get_drvdata(dev);
> 
>  	/* returning non-zero breaks out of class_for_each_device loop */
> -	if (epsy->of_node == np)
> +	if (device_match_of_node(epsy, np))
>  		return 1;
> 
>  	return 0;
> -- 
> 2.25.1

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)