linux-kernel - Re: [PATCH] pwm: mediatek: always use bus clock for PWM on MT7622

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221117115731.ryourz6nclatx4dw@pengutronix.de>
Date:   Thu, 17 Nov 2022 12:57:31 +0100
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
Cc:     Daniel Golle <daniel@...rotopia.org>, linux-pwm@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org,
        Thierry Reding <thierry.reding@...il.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Fabien Parent <fparent@...libre.com>,
        Zhi Mao <zhi.mao@...iatek.com>,
        Sam Shih <sam.shih@...iatek.com>
Subject: Re: [PATCH] pwm: mediatek: always use bus clock for PWM on MT7622

On Fri, Oct 28, 2022 at 10:39:31AM +0200, AngeloGioacchino Del Regno wrote:
> Il 26/10/22 02:56, Daniel Golle ha scritto:
> > According to MT7622 Reference Manual for Development Board v1.0 the PWM
> > unit found in the MT7622 SoC also comes with the PWM_CK_26M_SEL register
> > at offset 0x210 just like other modern MediaTek ARM64 SoCs.
> > And also MT7622 sets that register to 0x00000001 on reset which is
> > described as 'Select 26M fix CLK as BCLK' in the datasheet.
> > Hence set has_ck_26m_sel to true also for MT7622 which results in the
> > driver writing 0 to the PWM_CK_26M_SEL register which is described as
> > 'Select bus CLK as BCLK'.
> > 
> > Fixes: 0c0ead76235db0 ("pwm: mediatek: Always use bus clock")
> > Signed-off-by: Daniel Golle <daniel@...rotopia.org>
> 
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>

Acked-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)