linux-kernel - RE: [PATCH v3 01/10] iio: adis: add '__adis_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 18 Nov 2022 10:13:25 +0000
From:   "Sa, Nuno" <Nuno.Sa@...log.com>
To:     "Bolboaca, Ramona" <Ramona.Bolboaca@...log.com>,
        "jic23@...nel.org" <jic23@...nel.org>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "Bolboaca, Ramona" <Ramona.Bolboaca@...log.com>
Subject: RE: [PATCH v3 01/10] iio: adis: add '__adis_enable_irq()'
 implementation



> -----Original Message-----
> From: Ramona Bolboaca <ramona.bolboaca@...log.com>
> Sent: Friday, November 18, 2022 9:31 AM
> To: jic23@...nel.org; Sa, Nuno <Nuno.Sa@...log.com>; linux-
> iio@...r.kernel.org; linux-kernel@...r.kernel.org
> Cc: Bolboaca, Ramona <Ramona.Bolboaca@...log.com>
> Subject: [PATCH v3 01/10] iio: adis: add '__adis_enable_irq()' implementation
> 
> Add '__adis_enable_irq()' implementation which is the unlocked
> version of 'adis_enable_irq()'.
> 
> Signed-off-by: Ramona Bolboaca <ramona.bolboaca@...log.com>
> ---
> changes in v3:
>  - new patch
>  drivers/iio/imu/adis.c       | 26 +++++++++-----------------
>  include/linux/iio/imu/adis.h | 12 +++++++++++-
>  2 files changed, 20 insertions(+), 18 deletions(-)
> 
> diff --git a/drivers/iio/imu/adis.c b/drivers/iio/imu/adis.c
> index f7fcfd04f659..cfcb4abeb5db 100644
> --- a/drivers/iio/imu/adis.c
> +++ b/drivers/iio/imu/adis.c
> @@ -270,23 +270,19 @@ EXPORT_SYMBOL_NS(adis_debugfs_reg_access,
> IIO_ADISLIB);
>  #endif
> 
>  /**
> - * adis_enable_irq() - Enable or disable data ready IRQ
> + * __adis_enable_irq() - Enable or disable data ready IRQ (unlocked)
>   * @adis: The adis device
>   * @enable: Whether to enable the IRQ
>   *
>   * Returns 0 on success, negative error code otherwise
>   */
> -int adis_enable_irq(struct adis *adis, bool enable)
> +int __adis_enable_irq(struct adis *adis, bool enable)
>  {
> -	int ret = 0;
> +	int ret;

This change was not really needed as long as we 'return ret'
In the ' unmasked_drdy' case. Anyways, not a big deal for me...

- Nuno Sá