linux-kernel - RE: [PATCH v3 00/10] Add '__adis_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SJ0PR03MB6778AF1B1558319DB50D13E899099@SJ0PR03MB6778.namprd03.prod.outlook.com>
Date:   Fri, 18 Nov 2022 10:19:05 +0000
From:   "Sa, Nuno" <Nuno.Sa@...log.com>
To:     "Bolboaca, Ramona" <Ramona.Bolboaca@...log.com>,
        "jic23@...nel.org" <jic23@...nel.org>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "Bolboaca, Ramona" <Ramona.Bolboaca@...log.com>
Subject: RE: [PATCH v3 00/10] Add '__adis_enable_irq()'



> -----Original Message-----
> From: Ramona Bolboaca <ramona.bolboaca@...log.com>
> Sent: Friday, November 18, 2022 9:31 AM
> To: jic23@...nel.org; Sa, Nuno <Nuno.Sa@...log.com>; linux-
> iio@...r.kernel.org; linux-kernel@...r.kernel.org
> Cc: Bolboaca, Ramona <Ramona.Bolboaca@...log.com>
> Subject: [PATCH v3 00/10] Add '__adis_enable_irq()'
> 
> Added implementation for '__adis_enable_irq()' and called it instead of
> 'adis_enable_irq()' inside '__adis_initial_startup()'.
> Replaced 'adis_initial_startup()' calls in probe, with its unlocked
> variant.
> changes in v3:
>  new patches: 1,2
>  changed commit message for patches 2-9
> 
> Ramona Bolboaca (10):
>   iio: adis: add '__adis_enable_irq()' implementation
>   iio: adis: Call '__adis_enable_irq()' in '__adis_initial_startup()'
>   iio: accel: adis16201: Call '__adis_initial_startup()' in probe
>   iio: accel: adis16209: Call '__adis_initial_startup()' in probe
>   iio: gyro: adis16136: Call '__adis_initial_startup()' in probe
>   iio: gyro: adis16260: Call '__adis_initial_startup()' in probe
>   iio: imu: adis16400: Call '__adis_initial_startup()' in probe
>   staging: iio: accel: adis16203: Call '__adis_initial_startup()'
>   staging: iio: accel: adis16240: Call '__adis_initial_startup()'
>   iio: imu: adis: Remove adis_initial_startup function
> 
>  drivers/iio/accel/adis16201.c         |  2 +-
>  drivers/iio/accel/adis16209.c         |  2 +-
>  drivers/iio/gyro/adis16136.c          |  2 +-
>  drivers/iio/gyro/adis16260.c          |  2 +-
>  drivers/iio/imu/adis.c                | 28 ++++++++++-----------------
>  drivers/iio/imu/adis16400.c           |  2 +-
>  drivers/staging/iio/accel/adis16203.c |  2 +-
>  drivers/staging/iio/accel/adis16240.c |  2 +-
>  include/linux/iio/imu/adis.h          | 16 +++++++--------
>  9 files changed, 24 insertions(+), 34 deletions(-)
> 

I would squash patch 1 & 2 as we need to backport them both
and adding ''__adis_enable_irq()' is a direct consequence of fixing the
deadlock. Other than that:

Reviewed-by: Nuno Sá <nuno.sa@...log.com>