linux-kernel - Re: [PATCH 117/606] iio: light: apds9960: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJCx=g=WS=GeEMZ6U_Yk+JAnjYQ95mYk3rk9tB_dskoPxGNq0A@mail.gmail.com>
Date:   Sat, 19 Nov 2022 13:47:17 +0800
From:   Matt Ranostay <matt.ranostay@...sulko.com>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>
Cc:     Angel Iglesias <ang.iglesiasg@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Grant Likely <grant.likely@...aro.org>,
        Wolfram Sang <wsa@...nel.org>,
        Jonathan Cameron <jic23@...nel.org>,
        Jeremy Kerr <jk@...econstruct.com.au>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Alejandro Concepción Rodríguez 
        <asconcepcion@...ro.eu>, Miquel Raynal <miquel.raynal@...tlin.com>,
        Subhajit Ghosh <subhajit.ghosh@...technology.com>,
        linux-i2c@...r.kernel.org, kernel@...gutronix.de,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 117/606] iio: light: apds9960: Convert to i2c's .probe_new()

On Sat, Nov 19, 2022 at 6:46 AM Uwe Kleine-König <uwe@...ine-koenig.org> wrote:
>
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Looks good to me.

Acked-by: Matt Ranostay <matt.ranostay@...sulko.com>

> ---
>  drivers/iio/light/apds9960.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/light/apds9960.c b/drivers/iio/light/apds9960.c
> index a585ce0c122f..cc5974a95bd3 100644
> --- a/drivers/iio/light/apds9960.c
> +++ b/drivers/iio/light/apds9960.c
> @@ -988,8 +988,7 @@ static int apds9960_chip_init(struct apds9960_data *data)
>         return apds9960_set_powermode(data, 1);
>  }
>
> -static int apds9960_probe(struct i2c_client *client,
> -                         const struct i2c_device_id *id)
> +static int apds9960_probe(struct i2c_client *client)
>  {
>         struct apds9960_data *data;
>         struct iio_dev *indio_dev;
> @@ -1132,7 +1131,7 @@ static struct i2c_driver apds9960_driver = {
>                 .pm     = &apds9960_pm_ops,
>                 .acpi_match_table = apds9960_acpi_match,
>         },
> -       .probe          = apds9960_probe,
> +       .probe_new      = apds9960_probe,
>         .remove         = apds9960_remove,
>         .id_table       = apds9960_id,
>  };
> --
> 2.38.1
>