linux-kernel - Re: [PATCH 390/606] media: i2c/video-i2c: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJCx=g=7RMZyzmOecGG0F5ctArFa8Qsvyton8+2e1TaQ2gVg=g@mail.gmail.com>
Date:   Sat, 19 Nov 2022 13:51:09 +0800
From:   Matt Ranostay <matt.ranostay@...sulko.com>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>
Cc:     Angel Iglesias <ang.iglesiasg@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Grant Likely <grant.likely@...aro.org>,
        Wolfram Sang <wsa@...nel.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-i2c@...r.kernel.org, kernel@...gutronix.de,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 390/606] media: i2c/video-i2c: Convert to i2c's .probe_new()

On Sat, Nov 19, 2022 at 6:47 AM Uwe Kleine-König <uwe@...ine-koenig.org> wrote:
>
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
>
> .probe_new() doesn't get the i2c_device_id * parameter, so determine
> that explicitly in the probe function.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Looks good to me.

Acked-by: Matt Ranostay <matt.ranostay@...sulko.com>

> ---
>  drivers/media/i2c/video-i2c.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/i2c/video-i2c.c b/drivers/media/i2c/video-i2c.c
> index f15ef2d13059..dddf9827b314 100644
> --- a/drivers/media/i2c/video-i2c.c
> +++ b/drivers/media/i2c/video-i2c.c
> @@ -757,9 +757,9 @@ static void video_i2c_release(struct video_device *vdev)
>         kfree(data);
>  }
>
> -static int video_i2c_probe(struct i2c_client *client,
> -                            const struct i2c_device_id *id)
> +static int video_i2c_probe(struct i2c_client *client)
>  {
> +       const struct i2c_device_id *id = i2c_client_get_device_id(client);
>         struct video_i2c_data *data;
>         struct v4l2_device *v4l2_dev;
>         struct vb2_queue *queue;
> @@ -959,7 +959,7 @@ static struct i2c_driver video_i2c_driver = {
>                 .of_match_table = video_i2c_of_match,
>                 .pm     = &video_i2c_pm_ops,
>         },
> -       .probe          = video_i2c_probe,
> +       .probe_new      = video_i2c_probe,
>         .remove         = video_i2c_remove,
>         .id_table       = video_i2c_id_table,
>  };
> --
> 2.38.1
>