linux-kernel - Re: [PATCH 594/606] video: fbdev: matrox: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <75f7bba1-8dca-ff17-f922-e3465759ba66@gmx.de>
Date:   Sat, 19 Nov 2022 07:39:53 +0100
From:   Helge Deller <deller@....de>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>
Cc:     linux-i2c@...r.kernel.org, kernel@...gutronix.de,
        Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 594/606] video: fbdev: matrox: Convert to i2c's
 .probe_new()

On 11/18/22 23:45, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

applied.

Thanks!
Helge


> ---
>   drivers/video/fbdev/matrox/matroxfb_maven.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/video/fbdev/matrox/matroxfb_maven.c b/drivers/video/fbdev/matrox/matroxfb_maven.c
> index f2e02958673d..727a10a59811 100644
> --- a/drivers/video/fbdev/matrox/matroxfb_maven.c
> +++ b/drivers/video/fbdev/matrox/matroxfb_maven.c
> @@ -1249,8 +1249,7 @@ static int maven_shutdown_client(struct i2c_client* clnt) {
>   	return 0;
>   }
>
> -static int maven_probe(struct i2c_client *client,
> -		       const struct i2c_device_id *id)
> +static int maven_probe(struct i2c_client *client)
>   {
>   	struct i2c_adapter *adapter = client->adapter;
>   	int err = -ENODEV;
> @@ -1292,7 +1291,7 @@ static struct i2c_driver maven_driver={
>   	.driver = {
>   		.name	= "maven",
>   	},
> -	.probe		= maven_probe,
> +	.probe_new	= maven_probe,
>   	.remove		= maven_remove,
>   	.id_table	= maven_id,
>   };