linux-kernel - Re: [PATCH 358/606] media: i2c/ov6650: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGfqbt6HG88psov6CE2PqNn1YOdrc=TfYXHw8BgqrLbUc1MJRA@mail.gmail.com>
Date:   Sat, 19 Nov 2022 08:00:34 +0100
From:   Janusz Krzysztofik <jmkrzyszt@...il.com>
To:     Angel Iglesias <ang.iglesiasg@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Grant Likely <grant.likely@...aro.org>,
        Wolfram Sang <wsa@...nel.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
        Uwe Kleine-König <uwe@...ine-koenig.org>
Cc:     linux-i2c@...r.kernel.org, kernel@...gutronix.de,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 358/606] media: i2c/ov6650: Convert to i2c's .probe_new()

Dnia piątek, 18 listopada 2022 23:41:32 CET Uwe Kleine-König pisze:
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

LGTM

Acked-by: Janusz Krzysztofik <jmkrzyszt@...il.com>


> ---
>  drivers/media/i2c/ov6650.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/i2c/ov6650.c b/drivers/media/i2c/ov6650.c
> index 18f041e985b7..4c0ea2ae671b 100644
> --- a/drivers/media/i2c/ov6650.c
> +++ b/drivers/media/i2c/ov6650.c
> @@ -1025,8 +1025,7 @@ static const struct v4l2_subdev_internal_ops ov6650_internal_ops = {
>  /*
>   * i2c_driver function
>   */
> -static int ov6650_probe(struct i2c_client *client,
> -                     const struct i2c_device_id *did)
> +static int ov6650_probe(struct i2c_client *client)
>  {
>       struct ov6650 *priv;
>       int ret;
> @@ -1114,7 +1113,7 @@ static struct i2c_driver ov6650_i2c_driver = {
>       .driver = {
>               .name = "ov6650",
>       },
> -     .probe    = ov6650_probe,
> +     .probe_new = ov6650_probe,
>       .remove   = ov6650_remove,
>       .id_table = ov6650_id,
>  };
>