linux-kernel - Re: [PATCH 289/606] macintosh: ams/ams-i2c: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 19 Nov 2022 07:38:58 +0000
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>,
        Angel Iglesias <ang.iglesiasg@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Grant Likely <grant.likely@...aro.org>,
        Wolfram Sang <wsa@...nel.org>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Minghao Chi <chi.minghao@....com.cn>
CC:     "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 289/606] macintosh: ams/ams-i2c: Convert to i2c's
 .probe_new()



Le 18/11/2022 à 23:40, Uwe Kleine-König a écrit :
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

The patch itself and the others seems ok. But can you group all 
macintosh changes into a single patch instead of the 9 patches you sent ?

See the process about submitting patches, 
https://docs.kernel.org/process/submitting-patches.html and especially 
the "NO!!!! No more huge patch bombs to linux-kernel@...r.kernel.org 
people!" and the associated reference 
https://lore.kernel.org/all/20050711.125305.08322243.davem@davemloft.net/ :

	If you feel the need to send, say, more than 15 patches at once, 
reconsider.

Thanks
Christophe

> ---
>   drivers/macintosh/ams/ams-i2c.c | 8 +++-----
>   1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/macintosh/ams/ams-i2c.c b/drivers/macintosh/ams/ams-i2c.c
> index 3ded340699fb..a4a1035eb412 100644
> --- a/drivers/macintosh/ams/ams-i2c.c
> +++ b/drivers/macintosh/ams/ams-i2c.c
> @@ -56,8 +56,7 @@ enum ams_i2c_cmd {
>   	AMS_CMD_START,
>   };
>   
> -static int ams_i2c_probe(struct i2c_client *client,
> -			 const struct i2c_device_id *id);
> +static int ams_i2c_probe(struct i2c_client *client);
>   static void ams_i2c_remove(struct i2c_client *client);
>   
>   static const struct i2c_device_id ams_id[] = {
> @@ -70,7 +69,7 @@ static struct i2c_driver ams_i2c_driver = {
>   	.driver = {
>   		.name   = "ams",
>   	},
> -	.probe          = ams_i2c_probe,
> +	.probe_new      = ams_i2c_probe,
>   	.remove         = ams_i2c_remove,
>   	.id_table       = ams_id,
>   };
> @@ -155,8 +154,7 @@ static void ams_i2c_get_xyz(s8 *x, s8 *y, s8 *z)
>   	*z = ams_i2c_read(AMS_DATAZ);
>   }
>   
> -static int ams_i2c_probe(struct i2c_client *client,
> -			 const struct i2c_device_id *id)
> +static int ams_i2c_probe(struct i2c_client *client)
>   {
>   	int vmaj, vmin;
>   	int result;