linux-kernel - Re: [PATCH 228/606] Input: auo-pixcir-ts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 19 Nov 2022 09:41:56 +0100
From:   Heiko Stübner <heiko@...ech.de>
To:     Angel Iglesias <ang.iglesiasg@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Grant Likely <grant.likely@...aro.org>,
        Wolfram Sang <wsa@...nel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Uwe Kleine-König <uwe@...ine-koenig.org>
Cc:     linux-i2c@...r.kernel.org, kernel@...gutronix.de,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 228/606] Input: auo-pixcir-ts - Convert to i2c's .probe_new()

Am Freitag, 18. November 2022, 23:39:22 CET schrieb Uwe Kleine-König:
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Reviewed-by: Heiko Stuebner <heiko@...ech.de>

> ---
>  drivers/input/touchscreen/auo-pixcir-ts.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/auo-pixcir-ts.c b/drivers/input/touchscreen/auo-pixcir-ts.c
> index 2deae5a6823a..a4a1d58aeeac 100644
> --- a/drivers/input/touchscreen/auo-pixcir-ts.c
> +++ b/drivers/input/touchscreen/auo-pixcir-ts.c
> @@ -482,8 +482,7 @@ static void auo_pixcir_reset(void *data)
>  	gpiod_set_value_cansleep(ts->gpio_rst, 1);
>  }
>  
> -static int auo_pixcir_probe(struct i2c_client *client,
> -			    const struct i2c_device_id *id)
> +static int auo_pixcir_probe(struct i2c_client *client)
>  {
>  	struct auo_pixcir_ts *ts;
>  	struct input_dev *input_dev;
> @@ -637,7 +636,7 @@ static struct i2c_driver auo_pixcir_driver = {
>  		.pm	= &auo_pixcir_pm_ops,
>  		.of_match_table	= of_match_ptr(auo_pixcir_ts_dt_idtable),
>  	},
> -	.probe		= auo_pixcir_probe,
> +	.probe_new	= auo_pixcir_probe,
>  	.id_table	= auo_pixcir_idtable,
>  };
>  
>