linux-kernel - Re: [PATCH 454/606] mfd: rohm-bd718x7: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4c5b0723-db0c-0e94-e261-2e61183e92b2@gmail.com>
Date:   Sat, 19 Nov 2022 13:58:41 +0200
From:   Matti Vaittinen <mazziesaccount@...il.com>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>,
        Angel Iglesias <ang.iglesiasg@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Grant Likely <grant.likely@...aro.org>,
        Wolfram Sang <wsa@...nel.org>, Lee Jones <lee@...nel.org>
Cc:     linux-i2c@...r.kernel.org, kernel@...gutronix.de,
        Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 454/606] mfd: rohm-bd718x7: Convert to i2c's .probe_new()

On 11/19/22 00:43, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Acked-by: Matti Vaittinen <mazziesaccount@...il.com>

> ---
>   drivers/mfd/rohm-bd718x7.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mfd/rohm-bd718x7.c b/drivers/mfd/rohm-bd718x7.c
> index bfd81f78beae..3c766cb15a24 100644
> --- a/drivers/mfd/rohm-bd718x7.c
> +++ b/drivers/mfd/rohm-bd718x7.c
> @@ -127,8 +127,7 @@ static int bd718xx_init_press_duration(struct regmap *regmap,
>   	return 0;
>   }
>   
> -static int bd718xx_i2c_probe(struct i2c_client *i2c,
> -			    const struct i2c_device_id *id)
> +static int bd718xx_i2c_probe(struct i2c_client *i2c)
>   {
>   	struct regmap *regmap;
>   	struct regmap_irq_chip_data *irq_data;
> @@ -215,7 +214,7 @@ static struct i2c_driver bd718xx_i2c_driver = {
>   		.name = "rohm-bd718x7",
>   		.of_match_table = bd718xx_of_match,
>   	},
> -	.probe = bd718xx_i2c_probe,
> +	.probe_new = bd718xx_i2c_probe,
>   };
>   
>   static int __init bd718xx_i2c_init(void)

-- 
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~