linux-kernel - Re: [PATCH 054/606] iio: accel: kxcjk-1013: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y3jGHufAJVxZp1f0@smile.fi.intel.com>
Date:   Sat, 19 Nov 2022 14:03:42 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>
Cc:     Angel Iglesias <ang.iglesiasg@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Grant Likely <grant.likely@...aro.org>,
        Wolfram Sang <wsa@...nel.org>,
        Jonathan Cameron <jic23@...nel.org>,
        Jean Delvare <jdelvare@...e.de>,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        Dmitry Rokosov <DDRokosov@...rdevices.ru>,
        Miaoqian Lin <linmq006@...il.com>,
        wangjianli <wangjianli@...rlc.com>, linux-i2c@...r.kernel.org,
        kernel@...gutronix.de,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 054/606] iio: accel: kxcjk-1013: Convert to i2c's
 .probe_new()

On Fri, Nov 18, 2022 at 11:36:28PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> .probe_new() doesn't get the i2c_device_id * parameter, so determine
> that explicitly in the probe function.

Since there is no split on per subsystem basis (I mean, as a series targeting
only, let's say, IIO subsystem with cover letter), I'm answering here that all
IIO patches are good to me, thanks, Uwe!

Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
>  drivers/iio/accel/kxcjk-1013.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c
> index e626b6fa8a36..98da4bda22df 100644
> --- a/drivers/iio/accel/kxcjk-1013.c
> +++ b/drivers/iio/accel/kxcjk-1013.c
> @@ -1424,9 +1424,9 @@ static const char *kxcjk1013_match_acpi_device(struct device *dev,
>  	return dev_name(dev);
>  }
>  
> -static int kxcjk1013_probe(struct i2c_client *client,
> -			   const struct i2c_device_id *id)
> +static int kxcjk1013_probe(struct i2c_client *client)
>  {
> +	const struct i2c_device_id *id = i2c_client_get_device_id(client);
>  	static const char * const regulator_names[] = { "vdd", "vddio" };
>  	struct kxcjk1013_data *data;
>  	struct iio_dev *indio_dev;
> @@ -1732,7 +1732,7 @@ static struct i2c_driver kxcjk1013_driver = {
>  		.of_match_table = kxcjk1013_of_match,
>  		.pm	= &kxcjk1013_pm_ops,
>  	},
> -	.probe		= kxcjk1013_probe,
> +	.probe_new	= kxcjk1013_probe,
>  	.remove		= kxcjk1013_remove,
>  	.id_table	= kxcjk1013_id,
>  };
> -- 
> 2.38.1
> 

-- 
With Best Regards,
Andy Shevchenko