[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <884b308e-2775-4817-372b-a622cf382b72@redhat.com>
Date: Sat, 19 Nov 2022 13:57:11 +0100
From: Hans de Goede <hdegoede@...hat.com>
To: Uwe Kleine-König <uwe@...ine-koenig.org>,
Angel Iglesias <ang.iglesiasg@...il.com>,
Lee Jones <lee.jones@...aro.org>,
Grant Likely <grant.likely@...aro.org>,
Wolfram Sang <wsa@...nel.org>,
Dmitry Torokhov <dmitry.torokhov@...il.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: linux-i2c@...r.kernel.org, kernel@...gutronix.de,
Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 221/606] Input: elan_i2c_core - Convert to i2c's
.probe_new()
Hi,
On 11/18/22 23:39, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@...hat.com>
Regards,
Hans
> ---
> drivers/input/mouse/elan_i2c_core.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c
> index d4eb59b55bf1..a25d5b055553 100644
> --- a/drivers/input/mouse/elan_i2c_core.c
> +++ b/drivers/input/mouse/elan_i2c_core.c
> @@ -1188,8 +1188,7 @@ static void elan_disable_regulator(void *_data)
> regulator_disable(data->vcc);
> }
>
> -static int elan_probe(struct i2c_client *client,
> - const struct i2c_device_id *dev_id)
> +static int elan_probe(struct i2c_client *client)
> {
> const struct elan_transport_ops *transport_ops;
> struct device *dev = &client->dev;
> @@ -1438,7 +1437,7 @@ static struct i2c_driver elan_driver = {
> .probe_type = PROBE_PREFER_ASYNCHRONOUS,
> .dev_groups = elan_sysfs_groups,
> },
> - .probe = elan_probe,
> + .probe_new = elan_probe,
> .id_table = elan_id,
> };
>
Powered by blists - more mailing lists