lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 19 Nov 2022 13:57:20 +0100 From: Hans de Goede <hdegoede@...hat.com> To: Uwe Kleine-König <uwe@...ine-koenig.org>, Angel Iglesias <ang.iglesiasg@...il.com>, Lee Jones <lee.jones@...aro.org>, Grant Likely <grant.likely@...aro.org>, Wolfram Sang <wsa@...nel.org>, Dmitry Torokhov <dmitry.torokhov@...il.com> Cc: linux-i2c@...r.kernel.org, kernel@...gutronix.de, Uwe Kleine-König <u.kleine-koenig@...gutronix.de>, linux-input@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 231/606] Input: chipone_icn8318 - Convert to i2c's .probe_new() Hi, On 11/18/22 23:39, Uwe Kleine-König wrote: > From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de> > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@...hat.com> Regards, Hans > --- > drivers/input/touchscreen/chipone_icn8318.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/input/touchscreen/chipone_icn8318.c b/drivers/input/touchscreen/chipone_icn8318.c > index f2fb41fb031e..f6769e4bd4f2 100644 > --- a/drivers/input/touchscreen/chipone_icn8318.c > +++ b/drivers/input/touchscreen/chipone_icn8318.c > @@ -176,8 +176,7 @@ static int icn8318_resume(struct device *dev) > > static SIMPLE_DEV_PM_OPS(icn8318_pm_ops, icn8318_suspend, icn8318_resume); > > -static int icn8318_probe(struct i2c_client *client, > - const struct i2c_device_id *id) > +static int icn8318_probe(struct i2c_client *client) > { > struct device *dev = &client->dev; > struct icn8318_data *data; > @@ -267,7 +266,7 @@ static struct i2c_driver icn8318_driver = { > .pm = &icn8318_pm_ops, > .of_match_table = icn8318_of_match, > }, > - .probe = icn8318_probe, > + .probe_new = icn8318_probe, > .id_table = icn8318_i2c_id, > }; >
Powered by blists - more mailing lists