linux-kernel - Re: [PATCH 014/606] drm/bridge: adv7511: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y3kVXfxsPJNkq++H@pendragon.ideasonboard.com>
Date:   Sat, 19 Nov 2022 19:41:49 +0200
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>
Cc:     Angel Iglesias <ang.iglesiasg@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Grant Likely <grant.likely@...aro.org>,
        Wolfram Sang <wsa@...nel.org>,
        Andrzej Hajda <andrzej.hajda@...el.com>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Robert Foss <robert.foss@...aro.org>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Alvin Šipraga <alsi@...g-olufsen.dk>,
        Jeremy Kerr <jk@...econstruct.com.au>,
        Jagan Teki <jagan@...rulasolutions.com>,
        Ahmad Fatoum <a.fatoum@...gutronix.de>,
        Abhinav Kumar <quic_abhinavk@...cinc.com>,
        Jiasheng Jiang <jiasheng@...as.ac.cn>,
        linux-i2c@...r.kernel.org, kernel@...gutronix.de,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, Jonas Karlman <jonas@...boo.se>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 014/606] drm/bridge: adv7511: Convert to i2c's
 .probe_new()

On Fri, Nov 18, 2022 at 11:35:48PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> .probe_new() doesn't get the i2c_device_id * parameter, so determine
> that explicitly in the probe function.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>

> ---
>  drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> index e7a6e456ed0d..ddceafa7b637 100644
> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> @@ -1185,8 +1185,9 @@ static int adv7511_parse_dt(struct device_node *np,
>  	return 0;
>  }
>  
> -static int adv7511_probe(struct i2c_client *i2c, const struct i2c_device_id *id)
> +static int adv7511_probe(struct i2c_client *i2c)
>  {
> +	const struct i2c_device_id *id = i2c_client_get_device_id(i2c);
>  	struct adv7511_link_config link_config;
>  	struct adv7511 *adv7511;
>  	struct device *dev = &i2c->dev;
> @@ -1392,7 +1393,7 @@ static struct i2c_driver adv7511_driver = {
>  		.of_match_table = adv7511_of_ids,
>  	},
>  	.id_table = adv7511_i2c_ids,
> -	.probe = adv7511_probe,
> +	.probe_new = adv7511_probe,
>  	.remove = adv7511_remove,
>  };
>  
> -- 
> 2.38.1
> 

-- 
Regards,

Laurent Pinchart