linux-kernel - Re: [PATCH 092/606] iio: dac: ti-dac5571: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y3kVfm0zPb2E4VnG@pendragon.ideasonboard.com>
Date:   Sat, 19 Nov 2022 19:42:22 +0200
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>
Cc:     Angel Iglesias <ang.iglesiasg@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Grant Likely <grant.likely@...aro.org>,
        Wolfram Sang <wsa@...nel.org>,
        Jonathan Cameron <jic23@...nel.org>,
        Peter Rosin <peda@...ntia.se>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Antoniu Miclaus <antoniu.miclaus@...log.com>,
        Jose Cazarin <joseespiriki@...il.com>,
        linux-i2c@...r.kernel.org, kernel@...gutronix.de,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 092/606] iio: dac: ti-dac5571: Convert to i2c's
 .probe_new()

On Fri, Nov 18, 2022 at 11:37:06PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> .probe_new() doesn't get the i2c_device_id * parameter, so determine
> that explicitly in the probe function.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  drivers/iio/dac/ti-dac5571.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/dac/ti-dac5571.c b/drivers/iio/dac/ti-dac5571.c
> index 3210e3098f9a..40191947fea3 100644
> --- a/drivers/iio/dac/ti-dac5571.c
> +++ b/drivers/iio/dac/ti-dac5571.c
> @@ -306,9 +306,9 @@ static const struct iio_info dac5571_info = {
>  	.write_raw_get_fmt = dac5571_write_raw_get_fmt,
>  };
>  
> -static int dac5571_probe(struct i2c_client *client,
> -			 const struct i2c_device_id *id)
> +static int dac5571_probe(struct i2c_client *client)
>  {
> +	const struct i2c_device_id *id = i2c_client_get_device_id(client);
>  	struct device *dev = &client->dev;
>  	const struct dac5571_spec *spec;
>  	struct dac5571_data *data;
> @@ -426,7 +426,7 @@ static struct i2c_driver dac5571_driver = {
>  		   .name = "ti-dac5571",
>  		   .of_match_table = dac5571_of_id,
>  	},
> -	.probe	  = dac5571_probe,
> +	.probe_new = dac5571_probe,
>  	.remove   = dac5571_remove,
>  	.id_table = dac5571_id,
>  };
> -- 
> 2.38.1
> 

-- 
Regards,

Laurent Pinchart