linux-kernel - Re: [PATCH 352/606] media: i2c/mt9t001: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y3kWCIYGt4IR8qh0@pendragon.ideasonboard.com>
Date:   Sat, 19 Nov 2022 19:44:40 +0200
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>
Cc:     Angel Iglesias <ang.iglesiasg@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Grant Likely <grant.likely@...aro.org>,
        Wolfram Sang <wsa@...nel.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-i2c@...r.kernel.org, kernel@...gutronix.de,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 352/606] media: i2c/mt9t001: Convert to i2c's .probe_new()

On Fri, Nov 18, 2022 at 11:41:26PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  drivers/media/i2c/mt9t001.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/i2c/mt9t001.c b/drivers/media/i2c/mt9t001.c
> index d5abe4a7ef07..c635ed11388a 100644
> --- a/drivers/media/i2c/mt9t001.c
> +++ b/drivers/media/i2c/mt9t001.c
> @@ -856,8 +856,7 @@ static const struct v4l2_subdev_internal_ops mt9t001_subdev_internal_ops = {
>  	.close = mt9t001_close,
>  };
>  
> -static int mt9t001_probe(struct i2c_client *client,
> -			 const struct i2c_device_id *did)
> +static int mt9t001_probe(struct i2c_client *client)
>  {
>  	struct mt9t001_platform_data *pdata = client->dev.platform_data;
>  	struct mt9t001 *mt9t001;
> @@ -981,7 +980,7 @@ static struct i2c_driver mt9t001_driver = {
>  	.driver = {
>  		.name = "mt9t001",
>  	},
> -	.probe		= mt9t001_probe,
> +	.probe_new	= mt9t001_probe,
>  	.remove		= mt9t001_remove,
>  	.id_table	= mt9t001_id,
>  };
> -- 
> 2.38.1
> 

-- 
Regards,

Laurent Pinchart