linux-kernel - Re: [PATCH 355/606] media: i2c/mt9v032: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y3kWGQA2jXEUvVao@pendragon.ideasonboard.com>
Date:   Sat, 19 Nov 2022 19:44:57 +0200
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>
Cc:     Angel Iglesias <ang.iglesiasg@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Grant Likely <grant.likely@...aro.org>,
        Wolfram Sang <wsa@...nel.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-i2c@...r.kernel.org, kernel@...gutronix.de,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 355/606] media: i2c/mt9v032: Convert to i2c's .probe_new()

On Fri, Nov 18, 2022 at 11:41:29PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> .probe_new() doesn't get the i2c_device_id * parameter, so determine
> that explicitly in the probe function.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  drivers/media/i2c/mt9v032.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/i2c/mt9v032.c b/drivers/media/i2c/mt9v032.c
> index bc4388ccc2a8..7cfd4ebdd2e6 100644
> --- a/drivers/media/i2c/mt9v032.c
> +++ b/drivers/media/i2c/mt9v032.c
> @@ -1044,9 +1044,9 @@ mt9v032_get_pdata(struct i2c_client *client)
>  	return pdata;
>  }
>  
> -static int mt9v032_probe(struct i2c_client *client,
> -		const struct i2c_device_id *did)
> +static int mt9v032_probe(struct i2c_client *client)
>  {
> +	const struct i2c_device_id *did = i2c_client_get_device_id(client);
>  	struct mt9v032_platform_data *pdata = mt9v032_get_pdata(client);
>  	struct mt9v032 *mt9v032;
>  	unsigned int i;
> @@ -1296,7 +1296,7 @@ static struct i2c_driver mt9v032_driver = {
>  		.name = "mt9v032",
>  		.of_match_table = of_match_ptr(mt9v032_of_match),
>  	},
> -	.probe		= mt9v032_probe,
> +	.probe_new	= mt9v032_probe,
>  	.remove		= mt9v032_remove,
>  	.id_table	= mt9v032_id,
>  };
> -- 
> 2.38.1
> 

-- 
Regards,

Laurent Pinchart