linux-kernel - Re: [PATCH 571/606] serial: sc16is7xx: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <536ac08e-bdbd-b4d6-8309-8f6763f8db12@kernel.org>
Date:   Mon, 21 Nov 2022 07:03:41 +0100
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>,
        Angel Iglesias <ang.iglesiasg@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Grant Likely <grant.likely@...aro.org>,
        Wolfram Sang <wsa@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-i2c@...r.kernel.org, kernel@...gutronix.de,
        Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 571/606] serial: sc16is7xx: Convert to i2c's .probe_new()

On 18. 11. 22, 23:45, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> .probe_new() doesn't get the i2c_device_id * parameter, so determine
> that explicitly in the probe function.

I wonder why -- is this a new approach to probe functions? Or is only 
i2c affected? And why? Could you point to the commit introducing and 
describing the change in the i2c core?

> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
>   drivers/tty/serial/sc16is7xx.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
> index 39f92eb1e698..8412b25eac86 100644
> --- a/drivers/tty/serial/sc16is7xx.c
> +++ b/drivers/tty/serial/sc16is7xx.c
> @@ -1665,9 +1665,9 @@ MODULE_ALIAS("spi:sc16is7xx");
>   #endif
>   
>   #ifdef CONFIG_SERIAL_SC16IS7XX_I2C
> -static int sc16is7xx_i2c_probe(struct i2c_client *i2c,
> -			       const struct i2c_device_id *id)
> +static int sc16is7xx_i2c_probe(struct i2c_client *i2c)
>   {
> +	const struct i2c_device_id *id = i2c_client_get_device_id(i2c);
>   	const struct sc16is7xx_devtype *devtype;
>   	struct regmap *regmap;
>   
> @@ -1708,7 +1708,7 @@ static struct i2c_driver sc16is7xx_i2c_uart_driver = {
>   		.name		= SC16IS7XX_NAME,
>   		.of_match_table	= sc16is7xx_dt_ids,
>   	},
> -	.probe		= sc16is7xx_i2c_probe,
> +	.probe_new	= sc16is7xx_i2c_probe,
>   	.remove		= sc16is7xx_i2c_remove,
>   	.id_table	= sc16is7xx_i2c_id_table,
>   };

thanks,
-- 
js