linux-kernel - Re: [PATCH 509/606] of: unittest: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bc312919-26ca-7c15-4a67-6dabd59fe458@gmail.com>
Date:   Sun, 20 Nov 2022 19:44:00 -0600
From:   Frank Rowand <frowand.list@...il.com>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>,
        Angel Iglesias <ang.iglesiasg@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Grant Likely <grant.likely@...aro.org>,
        Wolfram Sang <wsa@...nel.org>, Rob Herring <robh+dt@...nel.org>
Cc:     linux-i2c@...r.kernel.org, kernel@...gutronix.de,
        Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 509/606] of: unittest: Convert to i2c's .probe_new()

On 11/18/22 16:44, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Add a prefix to the existing patch comment:

In struct i2c_driver, field new_probe replaces the soon to be deprecated
field probe.  Update unittest for this change.

> 
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---

Rob,

In patch 000/606 Uwe asks maintainers to pick up the individual patches
in their tree, so please pick up 509/606.

>  drivers/of/unittest.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
> index 1d810c0e18f8..bc0f1e50a4be 100644
> --- a/drivers/of/unittest.c
> +++ b/drivers/of/unittest.c
> @@ -2508,8 +2508,7 @@ static struct platform_driver unittest_i2c_bus_driver = {
>  	},
>  };
>  
> -static int unittest_i2c_dev_probe(struct i2c_client *client,
> -		const struct i2c_device_id *id)
> +static int unittest_i2c_dev_probe(struct i2c_client *client)
>  {
>  	struct device *dev = &client->dev;
>  	struct device_node *np = client->dev.of_node;
> @@ -2541,7 +2540,7 @@ static struct i2c_driver unittest_i2c_dev_driver = {
>  	.driver = {
>  		.name = "unittest-i2c-dev",
>  	},
> -	.probe = unittest_i2c_dev_probe,
> +	.probe_new = unittest_i2c_dev_probe,
>  	.remove = unittest_i2c_dev_remove,
>  	.id_table = unittest_i2c_dev_id,
>  };
> @@ -2553,8 +2552,7 @@ static int unittest_i2c_mux_select_chan(struct i2c_mux_core *muxc, u32 chan)
>  	return 0;
>  }
>  
> -static int unittest_i2c_mux_probe(struct i2c_client *client,
> -		const struct i2c_device_id *id)
> +static int unittest_i2c_mux_probe(struct i2c_client *client)
>  {
>  	int i, nchans;
>  	struct device *dev = &client->dev;
> @@ -2619,7 +2617,7 @@ static struct i2c_driver unittest_i2c_mux_driver = {
>  	.driver = {
>  		.name = "unittest-i2c-mux",
>  	},
> -	.probe = unittest_i2c_mux_probe,
> +	.probe_new = unittest_i2c_mux_probe,
>  	.remove = unittest_i2c_mux_remove,
>  	.id_table = unittest_i2c_mux_id,
>  };

Reviewed by visual inspection.  Did not do my normal build, test, check for
warnings.

Reviewed-by: Frank Rowand <frowand.list@...il.com>