[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y3tAHd9wzPNqpIzd@kuha.fi.intel.com>
Date: Mon, 21 Nov 2022 11:08:45 +0200
From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To: Uwe Kleine-König <uwe@...ine-koenig.org>
Cc: Angel Iglesias <ang.iglesiasg@...il.com>,
Lee Jones <lee.jones@...aro.org>,
Grant Likely <grant.likely@...aro.org>,
Wolfram Sang <wsa@...nel.org>,
Guenter Roeck <linux@...ck-us.net>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-i2c@...r.kernel.org, kernel@...gutronix.de,
Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>, linux-usb@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 582/606] usb: typec: tcpm/tcpci_rt1711h: Convert to i2c's
.probe_new()
On Fri, Nov 18, 2022 at 11:45:16PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> ---
> drivers/usb/typec/tcpm/tcpci_rt1711h.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpci_rt1711h.c b/drivers/usb/typec/tcpm/tcpci_rt1711h.c
> index 7b217c712c11..a0e9e3fe8564 100644
> --- a/drivers/usb/typec/tcpm/tcpci_rt1711h.c
> +++ b/drivers/usb/typec/tcpm/tcpci_rt1711h.c
> @@ -327,8 +327,7 @@ static int rt1711h_check_revision(struct i2c_client *i2c, struct rt1711h_chip *c
> return ret;
> }
>
> -static int rt1711h_probe(struct i2c_client *client,
> - const struct i2c_device_id *i2c_id)
> +static int rt1711h_probe(struct i2c_client *client)
> {
> int ret;
> struct rt1711h_chip *chip;
> @@ -413,7 +412,7 @@ static struct i2c_driver rt1711h_i2c_driver = {
> .name = "rt1711h",
> .of_match_table = of_match_ptr(rt1711h_of_match),
> },
> - .probe = rt1711h_probe,
> + .probe_new = rt1711h_probe,
> .remove = rt1711h_remove,
> .id_table = rt1711h_id,
> };
thanks,
--
heikki
Powered by blists - more mailing lists