linux-kernel - Re: [PATCH 583/606] usb: typec: ucsi/ucsi_ccg: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y3tARALjhs+QFfVb@kuha.fi.intel.com>
Date:   Mon, 21 Nov 2022 11:09:24 +0200
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>
Cc:     Angel Iglesias <ang.iglesiasg@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Grant Likely <grant.likely@...aro.org>,
        Wolfram Sang <wsa@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Sing-Han Chen <singhanc@...dia.com>,
        Sanket Goswami <Sanket.Goswami@....com>,
        linux-i2c@...r.kernel.org, kernel@...gutronix.de,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 583/606] usb: typec: ucsi/ucsi_ccg: Convert to i2c's
 .probe_new()

On Fri, Nov 18, 2022 at 11:45:17PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
>  drivers/usb/typec/ucsi/ucsi_ccg.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c b/drivers/usb/typec/ucsi/ucsi_ccg.c
> index 835f1c4372ba..46441f1477f2 100644
> --- a/drivers/usb/typec/ucsi/ucsi_ccg.c
> +++ b/drivers/usb/typec/ucsi/ucsi_ccg.c
> @@ -1338,8 +1338,7 @@ static struct attribute *ucsi_ccg_attrs[] = {
>  };
>  ATTRIBUTE_GROUPS(ucsi_ccg);
>  
> -static int ucsi_ccg_probe(struct i2c_client *client,
> -			  const struct i2c_device_id *id)
> +static int ucsi_ccg_probe(struct i2c_client *client)
>  {
>  	struct device *dev = &client->dev;
>  	struct ucsi_ccg *uc;
> @@ -1482,7 +1481,7 @@ static struct i2c_driver ucsi_ccg_driver = {
>  		.dev_groups = ucsi_ccg_groups,
>  		.acpi_match_table = amd_i2c_ucsi_match,
>  	},
> -	.probe = ucsi_ccg_probe,
> +	.probe_new = ucsi_ccg_probe,
>  	.remove = ucsi_ccg_remove,
>  	.id_table = ucsi_ccg_device_id,
>  };

thanks,

-- 
heikki