linux-kernel - Re: [PATCH 584/606] usb: typec: ucsi: stm32g0: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y3tAX8I3EWoIlraR@kuha.fi.intel.com>
Date:   Mon, 21 Nov 2022 11:09:51 +0200
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>
Cc:     Angel Iglesias <ang.iglesiasg@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Grant Likely <grant.likely@...aro.org>,
        Wolfram Sang <wsa@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Fabrice Gasnier <fabrice.gasnier@...s.st.com>,
        Corey Minyard <cminyard@...sta.com>,
        Colin Ian King <colin.i.king@...il.com>,
        linux-i2c@...r.kernel.org, kernel@...gutronix.de,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, linux-usb@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 584/606] usb: typec: ucsi: stm32g0: Convert to i2c's
 .probe_new()

On Fri, Nov 18, 2022 at 11:45:18PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
>  drivers/usb/typec/ucsi/ucsi_stm32g0.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/typec/ucsi/ucsi_stm32g0.c b/drivers/usb/typec/ucsi/ucsi_stm32g0.c
> index 7b92f0c8de70..93fead0096b7 100644
> --- a/drivers/usb/typec/ucsi/ucsi_stm32g0.c
> +++ b/drivers/usb/typec/ucsi/ucsi_stm32g0.c
> @@ -626,7 +626,7 @@ static int ucsi_stm32g0_probe_bootloader(struct ucsi *ucsi)
>  	return 0;
>  }
>  
> -static int ucsi_stm32g0_probe(struct i2c_client *client, const struct i2c_device_id *id)
> +static int ucsi_stm32g0_probe(struct i2c_client *client)
>  {
>  	struct device *dev = &client->dev;
>  	struct ucsi_stm32g0 *g0;
> @@ -763,7 +763,7 @@ static struct i2c_driver ucsi_stm32g0_i2c_driver = {
>  		.of_match_table = of_match_ptr(ucsi_stm32g0_typec_of_match),
>  		.pm = pm_sleep_ptr(&ucsi_stm32g0_pm_ops),
>  	},
> -	.probe = ucsi_stm32g0_probe,
> +	.probe_new = ucsi_stm32g0_probe,
>  	.remove = ucsi_stm32g0_remove,
>  	.id_table = ucsi_stm32g0_typec_i2c_devid
>  };

thanks,

-- 
heikki