[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <SJ0PR03MB62536F144270F8B01D3F0BDB8E0A9@SJ0PR03MB6253.namprd03.prod.outlook.com>
Date: Mon, 21 Nov 2022 09:46:10 +0000
From: "Hennerich, Michael" <Michael.Hennerich@...log.com>
To: Uwe Kleine-König <uwe@...ine-koenig.org>,
Angel Iglesias <ang.iglesiasg@...il.com>,
Lee Jones <lee.jones@...aro.org>,
Grant Likely <grant.likely@...aro.org>,
Wolfram Sang <wsa@...nel.org>,
Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>
CC: "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
"kernel@...gutronix.de" <kernel@...gutronix.de>,
Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 539/606] regulator: ad5398: Convert to i2c's .probe_new()
> -----Original Message-----
> From: Uwe Kleine-König <uwe@...ine-koenig.org>
> Sent: Freitag, 18. November 2022 23:45
> To: Angel Iglesias <ang.iglesiasg@...il.com>; Lee Jones
> <lee.jones@...aro.org>; Grant Likely <grant.likely@...aro.org>; Wolfram
> Sang <wsa@...nel.org>; Hennerich, Michael
> <Michael.Hennerich@...log.com>; Liam Girdwood
> <lgirdwood@...il.com>; Mark Brown <broonie@...nel.org>
> Cc: linux-i2c@...r.kernel.org; kernel@...gutronix.de; Uwe Kleine-König
> <u.kleine-koenig@...gutronix.de>; linux-kernel@...r.kernel.org
> Subject: [PATCH 539/606] regulator: ad5398: Convert to i2c's .probe_new()
>
>
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
>
> .probe_new() doesn't get the i2c_device_id * parameter, so determine that
> explicitly in the probe function.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Acked-by: Michael Hennerich <michael.hennerich@...log.com>
> ---
> drivers/regulator/ad5398.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/regulator/ad5398.c b/drivers/regulator/ad5398.c index
> 75f432f61e91..2ba8ac1773d1 100644
> --- a/drivers/regulator/ad5398.c
> +++ b/drivers/regulator/ad5398.c
> @@ -212,9 +212,9 @@ static const struct i2c_device_id ad5398_id[] = { };
> MODULE_DEVICE_TABLE(i2c, ad5398_id);
>
> -static int ad5398_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int ad5398_probe(struct i2c_client *client)
> {
> + const struct i2c_device_id *id = i2c_client_get_device_id(client);
> struct regulator_init_data *init_data = dev_get_platdata(&client-
> >dev);
> struct regulator_config config = { };
> struct ad5398_chip_info *chip;
> @@ -254,7 +254,7 @@ static int ad5398_probe(struct i2c_client *client, }
>
> static struct i2c_driver ad5398_driver = {
> - .probe = ad5398_probe,
> + .probe_new = ad5398_probe,
> .driver = {
> .name = "ad5398",
> },
> --
> 2.38.1
Powered by blists - more mailing lists