linux-kernel - RE: [PATCH 513/606] power: supply: adp5061: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Nov 2022 09:46:27 +0000
From:   "Hennerich, Michael" <Michael.Hennerich@...log.com>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>,
        Angel Iglesias <ang.iglesiasg@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Grant Likely <grant.likely@...aro.org>,
        Wolfram Sang <wsa@...nel.org>,
        Sebastian Reichel <sre@...nel.org>
CC:     "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 513/606] power: supply: adp5061: Convert to i2c's
 .probe_new()



> -----Original Message-----
> From: Uwe Kleine-König <uwe@...ine-koenig.org>
> Sent: Freitag, 18. November 2022 23:44
> To: Angel Iglesias <ang.iglesiasg@...il.com>; Lee Jones
> <lee.jones@...aro.org>; Grant Likely <grant.likely@...aro.org>; Wolfram
> Sang <wsa@...nel.org>; Hennerich, Michael
> <Michael.Hennerich@...log.com>; Sebastian Reichel <sre@...nel.org>
> Cc: linux-i2c@...r.kernel.org; kernel@...gutronix.de; Uwe Kleine-König
> <u.kleine-koenig@...gutronix.de>; linux-pm@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: [PATCH 513/606] power: supply: adp5061: Convert to i2c's
> .probe_new()
> 
> 
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Acked-by: Michael Hennerich <michael.hennerich@...log.com>

> ---
>  drivers/power/supply/adp5061.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/power/supply/adp5061.c
> b/drivers/power/supply/adp5061.c index fcf8ff0bc974..840db629a46c
> 100644
> --- a/drivers/power/supply/adp5061.c
> +++ b/drivers/power/supply/adp5061.c
> @@ -694,8 +694,7 @@ static const struct power_supply_desc adp5061_desc
> = {
>  	.num_properties		= ARRAY_SIZE(adp5061_props),
>  };
> 
> -static int adp5061_probe(struct i2c_client *client,
> -			 const struct i2c_device_id *id)
> +static int adp5061_probe(struct i2c_client *client)
>  {
>  	struct power_supply_config psy_cfg = {};
>  	struct adp5061_state *st;
> @@ -737,7 +736,7 @@ static struct i2c_driver adp5061_driver = {
>  	.driver = {
>  		.name = KBUILD_MODNAME,
>  	},
> -	.probe = adp5061_probe,
> +	.probe_new = adp5061_probe,
>  	.id_table = adp5061_id,
>  };
>  module_i2c_driver(adp5061_driver);
> --
> 2.38.1