linux-kernel - RE: [PATCH 417/606] mfd: adp5520: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Nov 2022 09:46:42 +0000
From:   "Hennerich, Michael" <Michael.Hennerich@...log.com>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>,
        Angel Iglesias <ang.iglesiasg@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Grant Likely <grant.likely@...aro.org>,
        Wolfram Sang <wsa@...nel.org>, Lee Jones <lee@...nel.org>
CC:     "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 417/606] mfd: adp5520: Convert to i2c's .probe_new()



> -----Original Message-----
> From: Uwe Kleine-König <uwe@...ine-koenig.org>
> Sent: Freitag, 18. November 2022 23:43
> To: Angel Iglesias <ang.iglesiasg@...il.com>; Lee Jones
> <lee.jones@...aro.org>; Grant Likely <grant.likely@...aro.org>; Wolfram
> Sang <wsa@...nel.org>; Hennerich, Michael
> <Michael.Hennerich@...log.com>; Lee Jones <lee@...nel.org>
> Cc: linux-i2c@...r.kernel.org; kernel@...gutronix.de; Uwe Kleine-König
> <u.kleine-koenig@...gutronix.de>; linux-kernel@...r.kernel.org
> Subject: [PATCH 417/606] mfd: adp5520: Convert to i2c's .probe_new()
> 
> 
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> .probe_new() doesn't get the i2c_device_id * parameter, so determine that
> explicitly in the probe function.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Acked-by: Michael Hennerich <michael.hennerich@...log.com>

> ---
>  drivers/mfd/adp5520.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mfd/adp5520.c b/drivers/mfd/adp5520.c index
> 882eddc32f8e..cb168efdbafe 100644
> --- a/drivers/mfd/adp5520.c
> +++ b/drivers/mfd/adp5520.c
> @@ -204,9 +204,9 @@ static int adp5520_remove_subdevs(struct
> adp5520_chip *chip)
>  	return device_for_each_child(chip->dev, NULL, __remove_subdev);  }
> 
> -static int adp5520_probe(struct i2c_client *client,
> -					const struct i2c_device_id *id)
> +static int adp5520_probe(struct i2c_client *client)
>  {
> +	const struct i2c_device_id *id = i2c_client_get_device_id(client);
>  	struct adp5520_platform_data *pdata = dev_get_platdata(&client-
> >dev);
>  	struct platform_device *pdev;
>  	struct adp5520_chip *chip;
> @@ -340,7 +340,7 @@ static struct i2c_driver adp5520_driver = {
>  		.pm			= pm_sleep_ptr(&adp5520_pm),
>  		.suppress_bind_attrs	= true,
>  	},
> -	.probe		= adp5520_probe,
> +	.probe_new	= adp5520_probe,
>  	.id_table	= adp5520_id,
>  };
>  builtin_i2c_driver(adp5520_driver);
> --
> 2.38.1