lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 21 Nov 2022 09:48:14 +0000 From: "Hennerich, Michael" <Michael.Hennerich@...log.com> To: Uwe Kleine-König <uwe@...ine-koenig.org>, Angel Iglesias <ang.iglesiasg@...il.com>, Lee Jones <lee.jones@...aro.org>, Grant Likely <grant.likely@...aro.org>, Wolfram Sang <wsa@...nel.org>, Dmitry Torokhov <dmitry.torokhov@...il.com> CC: "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>, "kernel@...gutronix.de" <kernel@...gutronix.de>, Uwe Kleine-König <u.kleine-koenig@...gutronix.de>, "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: RE: [PATCH 192/606] Input: adp5588-keys - Convert to i2c's .probe_new() > -----Original Message----- > From: Uwe Kleine-König <uwe@...ine-koenig.org> > Sent: Freitag, 18. November 2022 23:39 > To: Angel Iglesias <ang.iglesiasg@...il.com>; Lee Jones > <lee.jones@...aro.org>; Grant Likely <grant.likely@...aro.org>; Wolfram > Sang <wsa@...nel.org>; Hennerich, Michael > <Michael.Hennerich@...log.com>; Dmitry Torokhov > <dmitry.torokhov@...il.com> > Cc: linux-i2c@...r.kernel.org; kernel@...gutronix.de; Uwe Kleine-König > <u.kleine-koenig@...gutronix.de>; linux-input@...r.kernel.org; linux- > kernel@...r.kernel.org > Subject: [PATCH 192/606] Input: adp5588-keys - Convert to i2c's > .probe_new() > > > From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de> > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de> Acked-by: Michael Hennerich <michael.hennerich@...log.com> > --- > drivers/input/keyboard/adp5588-keys.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/input/keyboard/adp5588-keys.c > b/drivers/input/keyboard/adp5588-keys.c > index 7cd83c8e7110..72ae5ce72956 100644 > --- a/drivers/input/keyboard/adp5588-keys.c > +++ b/drivers/input/keyboard/adp5588-keys.c > @@ -718,8 +718,7 @@ static void adp5588_disable_regulator(void *reg) > regulator_disable(reg); > } > > -static int adp5588_probe(struct i2c_client *client, > - const struct i2c_device_id *id) > +static int adp5588_probe(struct i2c_client *client) > { > struct adp5588_kpad *kpad; > struct input_dev *input; > @@ -867,7 +866,7 @@ static struct i2c_driver adp5588_driver = { > .of_match_table = adp5588_of_match, > .pm = pm_sleep_ptr(&adp5588_dev_pm_ops), > }, > - .probe = adp5588_probe, > + .probe_new = adp5588_probe, > .remove = adp5588_remove, > .id_table = adp5588_id, > }; > -- > 2.38.1
Powered by blists - more mailing lists