linux-kernel - Re: [PATCH 067/606] iio: adc: max9611: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221121130104.ftptygyvtgzxplhv@uno.localdomain>
Date:   Mon, 21 Nov 2022 14:01:04 +0100
From:   Jacopo Mondi <jacopo@...ndi.org>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>
Cc:     Angel Iglesias <ang.iglesiasg@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Grant Likely <grant.likely@...aro.org>,
        Wolfram Sang <wsa@...nel.org>,
        Jonathan Cameron <jic23@...nel.org>,
        Jacopo Mondi <jacopo+renesas@...ndi.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        linux-i2c@...r.kernel.org, kernel@...gutronix.de,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 067/606] iio: adc: max9611: Convert to i2c's .probe_new()

Hi Uwe,

On Fri, Nov 18, 2022 at 11:36:41PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Acked-by: Jacopo Mondi <jacopo@...ndi.org>

Thanks
  j

> ---
>  drivers/iio/adc/max9611.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/max9611.c b/drivers/iio/adc/max9611.c
> index f982f00303dc..cb7f4785423a 100644
> --- a/drivers/iio/adc/max9611.c
> +++ b/drivers/iio/adc/max9611.c
> @@ -510,8 +510,7 @@ static const struct of_device_id max9611_of_table[] = {
>  };
>
>  MODULE_DEVICE_TABLE(of, max9611_of_table);
> -static int max9611_probe(struct i2c_client *client,
> -			 const struct i2c_device_id *id)
> +static int max9611_probe(struct i2c_client *client)
>  {
>  	const char * const shunt_res_prop = "shunt-resistor-micro-ohms";
>  	struct max9611_dev *max9611;
> @@ -557,7 +556,7 @@ static struct i2c_driver max9611_driver = {
>  		   .name = DRIVER_NAME,
>  		   .of_match_table = max9611_of_table,
>  	},
> -	.probe = max9611_probe,
> +	.probe_new = max9611_probe,
>  };
>  module_i2c_driver(max9611_driver);
>
> --
> 2.38.1
>