linux-kernel - Re: [PATCH 605/606] ipmi: ssif_bmc: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y3t2zHgeMlTRGE0t@minyard.net>
Date:   Mon, 21 Nov 2022 07:02:04 -0600
From:   Corey Minyard <minyard@....org>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>
Cc:     Angel Iglesias <ang.iglesiasg@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Grant Likely <grant.likely@...aro.org>,
        Wolfram Sang <wsa@...nel.org>, linux-i2c@...r.kernel.org,
        kernel@...gutronix.de,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        openipmi-developer@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 605/606] ipmi: ssif_bmc: Convert to i2c's .probe_new()

On Fri, Nov 18, 2022 at 11:45:39PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.

Thanks, queued for next release.

-corey

> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
>  drivers/char/ipmi/ssif_bmc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/char/ipmi/ssif_bmc.c b/drivers/char/ipmi/ssif_bmc.c
> index 2d8069386398..caee848261e9 100644
> --- a/drivers/char/ipmi/ssif_bmc.c
> +++ b/drivers/char/ipmi/ssif_bmc.c
> @@ -797,7 +797,7 @@ static int ssif_bmc_cb(struct i2c_client *client, enum i2c_slave_event event, u8
>  	return ret;
>  }
>  
> -static int ssif_bmc_probe(struct i2c_client *client, const struct i2c_device_id *id)
> +static int ssif_bmc_probe(struct i2c_client *client)
>  {
>  	struct ssif_bmc_ctx *ssif_bmc;
>  	int ret;
> @@ -860,7 +860,7 @@ static struct i2c_driver ssif_bmc_driver = {
>  		.name           = DEVICE_NAME,
>  		.of_match_table = ssif_bmc_match,
>  	},
> -	.probe          = ssif_bmc_probe,
> +	.probe_new      = ssif_bmc_probe,
>  	.remove         = ssif_bmc_remove,
>  	.id_table       = ssif_bmc_id,
>  };
> -- 
> 2.38.1
>