linux-kernel - Re: [PATCH 353/606] media: i2c/mt9t112: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Nov 2022 14:02:56 +0100
From:   Jacopo Mondi <jacopo@...ndi.org>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>
Cc:     Angel Iglesias <ang.iglesiasg@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Grant Likely <grant.likely@...aro.org>,
        Wolfram Sang <wsa@...nel.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Jean Delvare <jdelvare@...e.de>, Ajay Gupta <ajayg@...dia.com>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Miguel Ojeda <ojeda@...nel.org>, linux-i2c@...r.kernel.org,
        kernel@...gutronix.de,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 353/606] media: i2c/mt9t112: Convert to i2c's .probe_new()

Hi Uwe

On Fri, Nov 18, 2022 at 11:41:27PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---

Acked-by: Jacopo Mondi <jacopo@...ndi.org>


>  drivers/media/i2c/mt9t112.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/i2c/mt9t112.c b/drivers/media/i2c/mt9t112.c
> index ad564095d0cf..a82f056787b8 100644
> --- a/drivers/media/i2c/mt9t112.c
> +++ b/drivers/media/i2c/mt9t112.c
> @@ -1060,8 +1060,7 @@ static int mt9t112_camera_probe(struct i2c_client *client)
>  	return ret;
>  }
>
> -static int mt9t112_probe(struct i2c_client *client,
> -			 const struct i2c_device_id *did)
> +static int mt9t112_probe(struct i2c_client *client)
>  {
>  	struct mt9t112_priv *priv;
>  	int ret;
> @@ -1120,7 +1119,7 @@ static struct i2c_driver mt9t112_i2c_driver = {
>  	.driver = {
>  		.name = "mt9t112",
>  	},
> -	.probe    = mt9t112_probe,
> +	.probe_new = mt9t112_probe,
>  	.remove   = mt9t112_remove,
>  	.id_table = mt9t112_id,
>  };
> --
> 2.38.1
>