linux-kernel - Re: [PATCH 362/606] media: i2c/rj54n1cb0c: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221121130333.5mypzf67cki6f57f@uno.localdomain>
Date:   Mon, 21 Nov 2022 14:03:33 +0100
From:   Jacopo Mondi <jacopo@...ndi.org>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>
Cc:     Angel Iglesias <ang.iglesiasg@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Grant Likely <grant.likely@...aro.org>,
        Wolfram Sang <wsa@...nel.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Javier Martinez Canillas <javierm@...hat.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Crt Mori <cmo@...exis.com>,
        Marek Behún <kabel@...nel.org>,
        linux-i2c@...r.kernel.org, kernel@...gutronix.de,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 362/606] media: i2c/rj54n1cb0c: Convert to i2c's
 .probe_new()

Hi Uwe

On Fri, Nov 18, 2022 at 11:41:36PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Acked-by: Jacopo Mondi <jacopo@...ndi.org>

Thanks
  j

> ---
>  drivers/media/i2c/rj54n1cb0c.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/i2c/rj54n1cb0c.c b/drivers/media/i2c/rj54n1cb0c.c
> index 1c3502f34cd3..9db5473daba0 100644
> --- a/drivers/media/i2c/rj54n1cb0c.c
> +++ b/drivers/media/i2c/rj54n1cb0c.c
> @@ -1297,8 +1297,7 @@ static int rj54n1_video_probe(struct i2c_client *client,
>  	return ret;
>  }
>
> -static int rj54n1_probe(struct i2c_client *client,
> -			const struct i2c_device_id *did)
> +static int rj54n1_probe(struct i2c_client *client)
>  {
>  	struct rj54n1 *rj54n1;
>  	struct i2c_adapter *adapter = client->adapter;
> @@ -1422,7 +1421,7 @@ static struct i2c_driver rj54n1_i2c_driver = {
>  	.driver = {
>  		.name = "rj54n1cb0c",
>  	},
> -	.probe		= rj54n1_probe,
> +	.probe_new	= rj54n1_probe,
>  	.remove		= rj54n1_remove,
>  	.id_table	= rj54n1_id,
>  };
> --
> 2.38.1
>