| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202211230208.fD06OTAG-lkp@intel.com>
Date: Wed, 23 Nov 2022 02:43:24 +0800
From: kernel test robot <lkp@...el.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Jakob Koschel <jakobkoschel@...il.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Mathias Nyman <mathias.nyman@...ux.intel.com>,
intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev,
Tvrtko Ursulin <tvrtko.ursulin@...ux.intel.com>,
Kevin Cernekee <cernekee@...il.com>,
Jani Nikula <jani.nikula@...el.com>,
Hans de Goede <hdegoede@...hat.com>,
Rodrigo Vivi <rodrigo.vivi@...el.com>
Subject: Re: [PATCH v3 1/4] i915: Move list_count() to list.h for broader use
Hi Andy,
I love your patch! Yet something to improve:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on usb/usb-next usb/usb-linus drm-intel/for-linux-next drm-intel/for-linux-next-fixes linus/master v6.1-rc6 next-20221122]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/i915-Move-list_count-to-list-h-for-broader-use/20221122-233657
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
patch link: https://lore.kernel.org/r/20221122153516.52577-1-andriy.shevchenko%40linux.intel.com
patch subject: [PATCH v3 1/4] i915: Move list_count() to list.h for broader use
config: s390-defconfig
compiler: s390-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/3d217ef769536f160f5c20224aeb0f9070bdfdcf
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Andy-Shevchenko/i915-Move-list_count-to-list-h-for-broader-use/20221122-233657
git checkout 3d217ef769536f160f5c20224aeb0f9070bdfdcf
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 prepare
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
scripts/genksyms/parse.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples
In file included from include/linux/preempt.h:11,
from include/linux/percpu.h:6,
from include/linux/context_tracking_state.h:5,
from include/linux/hardirq.h:5,
from include/linux/kvm_host.h:7,
from arch/s390/kernel/asm-offsets.c:11:
include/linux/list.h:662:8: warning: no previous prototype for 'list_count' [-Wmissing-prototypes]
662 | size_t list_count(struct list_head *head)
| ^~~~~~~~~~
In file included from include/linux/preempt.h:11,
from arch/s390/include/asm/timex.h:13,
from arch/s390/kernel/vdso64/getcpu.c:6:
include/linux/list.h:662:8: warning: no previous prototype for 'list_count' [-Wmissing-prototypes]
662 | size_t list_count(struct list_head *head)
| ^~~~~~~~~~
In file included from include/linux/rculist.h:10,
from include/linux/pid.h:5,
from include/linux/sched.h:14,
from arch/s390/include/asm/syscall.h:13,
from arch/s390/include/asm/vdso/gettimeofday.h:9,
from include/vdso/datapage.h:137,
from arch/s390/kernel/vdso64/../../../../lib/vdso/gettimeofday.c:5,
from arch/s390/kernel/vdso64/vdso64_generic.c:2:
include/linux/list.h:662:8: warning: no previous prototype for 'list_count' [-Wmissing-prototypes]
662 | size_t list_count(struct list_head *head)
| ^~~~~~~~~~
s390-linux-ld: arch/s390/kernel/vdso64/getcpu.o: in function `list_count':
>> include/linux/list.h:663: multiple definition of `list_count'; arch/s390/kernel/vdso64/vdso64_generic.o:include/linux/list.h:663: first defined here
make[2]: *** [arch/s390/kernel/vdso64/Makefile:50: arch/s390/kernel/vdso64/vdso64.so.dbg] Error 1
make[2]: Target 'include/generated/vdso64-offsets.h' not remade because of errors.
make[1]: *** [arch/s390/Makefile:159: vdso_prepare] Error 2
make[1]: Target 'prepare' not remade because of errors.
make: *** [Makefile:231: __sub-make] Error 2
make: Target 'prepare' not remade because of errors.
vim +663 include/linux/list.h
557
558 /**
559 * list_next_entry - get the next element in list
560 * @pos: the type * to cursor
561 * @member: the name of the list_head within the struct.
562 */
563 #define list_next_entry(pos, member) \
564 list_entry((pos)->member.next, typeof(*(pos)), member)
565
566 /**
567 * list_next_entry_circular - get the next element in list
568 * @pos: the type * to cursor.
569 * @head: the list head to take the element from.
570 * @member: the name of the list_head within the struct.
571 *
572 * Wraparound if pos is the last element (return the first element).
573 * Note, that list is expected to be not empty.
574 */
575 #define list_next_entry_circular(pos, head, member) \
576 (list_is_last(&(pos)->member, head) ? \
577 list_first_entry(head, typeof(*(pos)), member) : list_next_entry(pos, member))
578
579 /**
580 * list_prev_entry - get the prev element in list
581 * @pos: the type * to cursor
582 * @member: the name of the list_head within the struct.
583 */
584 #define list_prev_entry(pos, member) \
585 list_entry((pos)->member.prev, typeof(*(pos)), member)
586
587 /**
588 * list_prev_entry_circular - get the prev element in list
589 * @pos: the type * to cursor.
590 * @head: the list head to take the element from.
591 * @member: the name of the list_head within the struct.
592 *
593 * Wraparound if pos is the first element (return the last element).
594 * Note, that list is expected to be not empty.
595 */
596 #define list_prev_entry_circular(pos, head, member) \
597 (list_is_first(&(pos)->member, head) ? \
598 list_last_entry(head, typeof(*(pos)), member) : list_prev_entry(pos, member))
599
600 /**
601 * list_for_each - iterate over a list
602 * @pos: the &struct list_head to use as a loop cursor.
603 * @head: the head for your list.
604 */
605 #define list_for_each(pos, head) \
606 for (pos = (head)->next; !list_is_head(pos, (head)); pos = pos->next)
607
608 /**
609 * list_for_each_rcu - Iterate over a list in an RCU-safe fashion
610 * @pos: the &struct list_head to use as a loop cursor.
611 * @head: the head for your list.
612 */
613 #define list_for_each_rcu(pos, head) \
614 for (pos = rcu_dereference((head)->next); \
615 !list_is_head(pos, (head)); \
616 pos = rcu_dereference(pos->next))
617
618 /**
619 * list_for_each_continue - continue iteration over a list
620 * @pos: the &struct list_head to use as a loop cursor.
621 * @head: the head for your list.
622 *
623 * Continue to iterate over a list, continuing after the current position.
624 */
625 #define list_for_each_continue(pos, head) \
626 for (pos = pos->next; !list_is_head(pos, (head)); pos = pos->next)
627
628 /**
629 * list_for_each_prev - iterate over a list backwards
630 * @pos: the &struct list_head to use as a loop cursor.
631 * @head: the head for your list.
632 */
633 #define list_for_each_prev(pos, head) \
634 for (pos = (head)->prev; !list_is_head(pos, (head)); pos = pos->prev)
635
636 /**
637 * list_for_each_safe - iterate over a list safe against removal of list entry
638 * @pos: the &struct list_head to use as a loop cursor.
639 * @n: another &struct list_head to use as temporary storage
640 * @head: the head for your list.
641 */
642 #define list_for_each_safe(pos, n, head) \
643 for (pos = (head)->next, n = pos->next; \
644 !list_is_head(pos, (head)); \
645 pos = n, n = pos->next)
646
647 /**
648 * list_for_each_prev_safe - iterate over a list backwards safe against removal of list entry
649 * @pos: the &struct list_head to use as a loop cursor.
650 * @n: another &struct list_head to use as temporary storage
651 * @head: the head for your list.
652 */
653 #define list_for_each_prev_safe(pos, n, head) \
654 for (pos = (head)->prev, n = pos->prev; \
655 !list_is_head(pos, (head)); \
656 pos = n, n = pos->prev)
657
658 /**
659 * list_count - count nodes in the list
660 * @head: the head for your list.
661 */
662 size_t list_count(struct list_head *head)
> 663 {
664 struct list_head *pos;
665 size_t count = 0;
666
667 list_for_each(pos, head)
668 count++;
669
670 return count;
671 }
672
--
0-DAY CI Kernel Test Service
https://01.org/lkp
View attachment "config" of type "text/plain" (89447 bytes)
Powered by blists - more mailing lists