linux-kernel - Re: [PATCH] perf/amlogic: Fix build error for x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8038935f-4ca4-ee13-2088-009a57b88baf@linaro.org>
Date:   Tue, 22 Nov 2022 09:35:13 +0100
From:   Neil Armstrong <neil.armstrong@...aro.org>
To:     Jiucheng Xu <jiucheng.xu@...ogic.com>,
        Will Deacon <will@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Kevin Hilman <khilman@...libre.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Cc:     Jianxin Pan <jianxin.pan@...ogic.com>,
        Kelvin Zhang <kelvin.zhang@...ogic.com>,
        Chris Healy <cphealy@...il.com>,
        Chris Healy <healych@...zon.com>,
        linux-amlogic@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf/amlogic: Fix build error for x86_64 allmodconfig

On 22/11/2022 08:50, Jiucheng Xu wrote:
> The driver misses including <linux/io.h>. It causes
> compiling error "implicit declaration of function
> 'readl' and 'writel'" when make X86_64 allmodconfig.
> 
> Fixs: '2016e2113d35b ("perf/amlogic: Add support for
> Amlogic meson G12 SoC DDR PMU driver")'
> Signed-off-by: Jiucheng Xu <jiucheng.xu@...ogic.com>
> ---
>   drivers/perf/amlogic/meson_g12_ddr_pmu.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/perf/amlogic/meson_g12_ddr_pmu.c b/drivers/perf/amlogic/meson_g12_ddr_pmu.c
> index c07c34f03cce..932802abd18c 100644
> --- a/drivers/perf/amlogic/meson_g12_ddr_pmu.c
> +++ b/drivers/perf/amlogic/meson_g12_ddr_pmu.c
> @@ -4,6 +4,7 @@
>    */
>   
>   #include <linux/err.h>
> +#include <linux/io.h>
>   #include <linux/kernel.h>
>   #include <linux/module.h>
>   #include <linux/of.h>


Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>