linux-kernel - Re: [PATCH 171/606] iio: pressure: icp10100: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <FR3P281MB175731CA2BA30F163D059375CE0D9@FR3P281MB1757.DEUP281.PROD.OUTLOOK.COM>
Date:   Tue, 22 Nov 2022 10:07:23 +0000
From:   Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@....com>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>,
        Angel Iglesias <ang.iglesiasg@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Grant Likely <grant.likely@...aro.org>,
        Wolfram Sang <wsa@...nel.org>,
        Jonathan Cameron <jic23@...nel.org>
CC:     "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 171/606] iio: pressure: icp10100: Convert to i2c's
 .probe_new()

Hello,

looks good, thanks for the patch.

Acked-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@....com>

Best regards,
JB



From: Uwe Kleine-König <uwe@...ine-koenig.org>
Sent: Friday, November 18, 2022 23:38
To: Angel Iglesias <ang.iglesiasg@...il.com>; Lee Jones <lee.jones@...aro.org>; Grant Likely <grant.likely@...aro.org>; Wolfram Sang <wsa@...nel.org>; Jonathan Cameron <jic23@...nel.org>; Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@....com>
Cc: linux-i2c@...r.kernel.org <linux-i2c@...r.kernel.org>; kernel@...gutronix.de <kernel@...gutronix.de>; Uwe Kleine-König <u.kleine-koenig@...gutronix.de>; Lars-Peter Clausen <lars@...afoo.de>; linux-iio@...r.kernel.org <linux-iio@...r.kernel.org>; linux-kernel@...r.kernel.org <linux-kernel@...r.kernel.org>
Subject: [PATCH 171/606] iio: pressure: icp10100: Convert to i2c's .probe_new() 
 
[CAUTION] This is an EXTERNAL email. Do not click links or open attachments unless you recognize the sender and know the content is safe.

======================================================================
From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
---
 drivers/iio/pressure/icp10100.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/iio/pressure/icp10100.c b/drivers/iio/pressure/icp10100.c
index b62f28585db5..407cf25ea0e3 100644
--- a/drivers/iio/pressure/icp10100.c
+++ b/drivers/iio/pressure/icp10100.c
@@ -530,8 +530,7 @@ static void icp10100_pm_disable(void *data)
         pm_runtime_disable(dev);
 }
 
-static int icp10100_probe(struct i2c_client *client,
-                         const struct i2c_device_id *id)
+static int icp10100_probe(struct i2c_client *client)
 {
         struct iio_dev *indio_dev;
         struct icp10100_state *st;
@@ -649,7 +648,7 @@ static struct i2c_driver icp10100_driver = {
                 .pm = pm_ptr(&icp10100_pm),
                 .of_match_table = icp10100_of_match,
         },
-       .probe = icp10100_probe,
+       .probe_new = icp10100_probe,
         .id_table = icp10100_id,
 };
 module_i2c_driver(icp10100_driver);
-- 
2.38.1